[Java.time] Retain prefixed date pattern in formatter#48703
[Java.time] Retain prefixed date pattern in formatter#48703pgomulka merged 12 commits intoelastic:7.xfrom
Conversation
|
@elasticmachine run elasticsearch-ci/bwc |
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
@elasticmachine run elasticsearch-ci/2 |
|
ok to test |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/1 |
rjernst
left a comment
There was a problem hiding this comment.
The change looks good. Can you clarify which versions this is intended for? I see the v8.0.0 label, but the PR is against 7.x (which I believe is correct).
|
@rjernst this I think should go to v8, v7.x and v6.8 I wasn't able to confirm this failing same way when Master node was on 7 and non-master node was on 6.8. It was always passing for me. I still think this should go to 6.8 branch as well. I am yet to try to reproduce this on v8 and v7 mixed cluster. |
JavaDateFormatter should keep the pattern with the prefixed 8 as it will be used for serialisation. The stripped pattern should be used for the enclosed formatters. closes elastic#48698
|
If this goes to master, what is the plan to remove it? We need a cutoff, which seemed like 7.x. At some point we need to convert these back to removing the 8 prefix, and between master and 7.x it should not be necessary since all formats are java 8 format. |
|
@rjernst you are right, this is not needed in master. When upgrading from 7.x to master users are not meant to have |
JavaDateFormatter should keep the pattern with the prefixed
8as it will be used for serialisation. The stripped pattern should be used for the enclosed formatters.closes #48698