Skip to content

Remove some usages of MapBuilder#immutableMap#41593

Merged
jasontedor merged 6 commits intoelastic:masterfrom
jasontedor:map-builder-immutable-map-v1
Apr 28, 2019
Merged

Remove some usages of MapBuilder#immutableMap#41593
jasontedor merged 6 commits intoelastic:masterfrom
jasontedor:map-builder-immutable-map-v1

Conversation

@jasontedor
Copy link
Copy Markdown
Member

This method can be replaced by some convenience collection factory methods available in the JDK now. This commit does not attempt to replace all usages, only enough that the size of the commit is kept to a reasonable size.

This method can be replaced by some convenience collection factory
methods available in the JDK now. This commit does not attempt to
replace all usages, only enough that the size of the commit is kept to a
reasonable size.
@jasontedor jasontedor added >non-issue :Core/Infra/Core Core issues without another label v8.0.0 labels Apr 26, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

@jasontedor jasontedor requested a review from rjernst April 26, 2019 22:42
@jasontedor
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/1

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/1

…ble-map-v1

* elastic/master:
  Adjust bwc version (elastic#41099)
  Fix multi-node parsing in voting config exclusions REST API (elastic#41588)
  Add missing skip: arbitrary_key (elastic#41492)
  [ML] cleanup + adding description field to transforms (elastic#41554)
@jasontedor
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/1

1 similar comment
@jasontedor
Copy link
Copy Markdown
Member Author

@elasticmachine run elasticsearch-ci/1

@jasontedor
Copy link
Copy Markdown
Member Author

The failure in the packaging sample will be addressed by #41626.

@jasontedor jasontedor merged commit 545e56d into elastic:master Apr 28, 2019
@jasontedor jasontedor deleted the map-builder-immutable-map-v1 branch April 28, 2019 23:55
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
This method can be replaced by some convenience collection factory
methods available in the JDK now. This commit does not attempt to
replace all usages, only enough that the size of the commit is kept to a
reasonable size.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This method can be replaced by some convenience collection factory
methods available in the JDK now. This commit does not attempt to
replace all usages, only enough that the size of the commit is kept to a
reasonable size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >non-issue v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants