[ML] cleanup + adding description field to transforms#41554
Merged
benwtrent merged 2 commits intoelastic:masterfrom Apr 26, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core |
davidkyle
approved these changes
Apr 26, 2019
Member
davidkyle
left a comment
There was a problem hiding this comment.
LGTM left some minor comments
| * Checks that the given {@code timeValue} is a non-negative multiple value of the {@code baseUnit}. | ||
| * | ||
| * <ul> | ||
| * <li>400ms is valid for base unit of seconds</li> |
Member
There was a problem hiding this comment.
Is this comment correct? Should it be 200ms or 500ms i.e. something that divides 1000ms/1s
| * Checks that the given {@code timeValue} is a positive multiple value of the {@code baseUnit}. | ||
| * | ||
| * <ul> | ||
| * <li>400ms is valid for base unit of seconds</li> |
Member
There was a problem hiding this comment.
Same comment about the comment
| .endObject() | ||
| .endObject() | ||
| .startObject(DataFrameTransformConfig.DESCRIPTION.getPreferredName()) | ||
| .field(TYPE, TEXT) |
Member
There was a problem hiding this comment.
Text fields are analysed is this what you want
Member
Author
There was a problem hiding this comment.
@davidkyle, I thought it would be nice to be able to search for dataframe configs via their descriptions. What do you think @hendrikmuhs ?
There was a problem hiding this comment.
sounds reasonable to me to provide full text search for it.
Devil's advocate: Let's limit the size of the description.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 26, 2019
* [ML] cleanup + adding description field to transforms * making description length have a max of 1k
benwtrent
added a commit
that referenced
this pull request
Apr 26, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 27, 2019
…ble-map-v1 * elastic/master: Adjust bwc version (elastic#41099) Fix multi-node parsing in voting config exclusions REST API (elastic#41588) Add missing skip: arbitrary_key (elastic#41492) [ML] cleanup + adding description field to transforms (elastic#41554)
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
* [ML] cleanup + adding description field to transforms * making description length have a max of 1k
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* [ML] cleanup + adding description field to transforms * making description length have a max of 1k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of places where we import
core.mlclasses into transforms. I am not sure this is the correct thing to do. There are very few exceptions to the "don't share code between plugins" ideology (one of them is thesecurityplugin). So, I opted to create anExceptionsHelperclass in data frames and use it. Same forTimeUtilsThis PR also adds a
descriptionfield to the data frame transforms.