[ML] cleanup + adding description field to transforms (#41554)#41605
Merged
benwtrent merged 1 commit intoelastic:7.xfrom Apr 26, 2019
Merged
Conversation
* [ML] cleanup + adding description field to transforms * making description length have a max of 1k
Collaborator
|
Pinging @elastic/ml-core |
Member
Author
|
run elasticsearch-ci/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of places where we import
core.mlclasses into transforms. I am not sure this is the correct thing to do. There are very few exceptions to the "don't share code between plugins" ideology (one of them is thesecurityplugin). So, I opted to create anExceptionsHelperclass in data frames and use it. Same forTimeUtilsThis PR also adds a
descriptionfield to the data frame transforms.Backport of #41554