Configure TMP for test nodes on Windows#39959
Merged
alpar-t merged 3 commits intoelastic:masterfrom Mar 13, 2019
Merged
Conversation
This breaks on windows where TMP dir default to C:\Windows and startup fails with a permission error. I tried to create a tmp dir and pass in `TMP` env, but it lead to a class not found error, and since testclusers is already independent of the calling environment I stopped there.
Member
|
The new environment is necessary; otherwise we pass through JAVA_HOME and always use that, even when we want to use the bundled jdk. I think we can solve this by passing through whatever env vars windows needs? |
Fix incorrect argument for paths with spaces
Contributor
Author
|
Thanks @rjernst I was too quick on that one. I added |
rjernst
approved these changes
Mar 13, 2019
Member
rjernst
left a comment
There was a problem hiding this comment.
LGTM, one optional suggestion
| // Since we configure ant to run with a new environment above, we need to set this to a dir we have access to | ||
| File tmpDir = new File(node.baseDir, "tmp") | ||
| tmpDir.mkdirs() | ||
| env(key: "TMP", value: tmpDir.absolutePath) |
Member
There was a problem hiding this comment.
shouldn't we just pass through TMP? this would match the previous behavior where the environment was inherited
alpar-t
added a commit
that referenced
this pull request
Mar 13, 2019
This breaks on windows where TMP dir default to C:\Windows and startup fails with a permission error. I tried to create a tmp dir and pass in `TMP` env, but it lead to a class not found error, and since testclusers is already independent of the calling environment I stopped there.
alpar-t
added a commit
that referenced
this pull request
Mar 13, 2019
This breaks on windows where TMP dir default to C:\Windows and startup fails with a permission error. I tried to create a tmp dir and pass in `TMP` env, but it lead to a class not found error, and since testclusers is already independent of the calling environment I stopped there.
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Mar 13, 2019
This breaks on windows where TMP dir default to C:\Windows and startup fails with a permission error. I tried to create a tmp dir and pass in `TMP` env, but it lead to a class not found error, and since testclusers is already independent of the calling environment I stopped there.
ebadyano
added a commit
to ebadyano/rally-teams
that referenced
this pull request
Mar 14, 2019
After elasticsearch change, ${ES_TMPDIR} needs quotes around it.
Relates elastic/elasticsearch#39959
ebadyano
added a commit
to elastic/rally-teams
that referenced
this pull request
Mar 14, 2019
After elasticsearch change, ${ES_TMPDIR} needs quotes around it.
Relates elastic/elasticsearch#39959
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Mar 21, 2019
This reverts commit 97562a8.
alpar-t
added a commit
that referenced
this pull request
Mar 26, 2019
alpar-t
added a commit
that referenced
this pull request
Mar 26, 2019
alpar-t
added a commit
that referenced
this pull request
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows TMP dir default to C:\Windows and startup fails with a permission error.
The reason we don't see this more is that typically windows has TMP defined in users environment, but with
newenvironment: truethis is not passed along.Closes #39904.