Update Djava.io.tmpdir parameter in jvm.options to add quotes#21
Merged
ebadyano merged 1 commit intoelastic:masterfrom Mar 14, 2019
Merged
Update Djava.io.tmpdir parameter in jvm.options to add quotes#21ebadyano merged 1 commit intoelastic:masterfrom
ebadyano merged 1 commit intoelastic:masterfrom
Conversation
After elasticsearch change, ${ES_TMPDIR} needs quotes around it.
Relates elastic/elasticsearch#39959
dliappis
approved these changes
Mar 14, 2019
Contributor
dliappis
left a comment
There was a problem hiding this comment.
LGTM. If this ends up being required without a follow-up change in master/7 we'll need to back this commit to branch 7 of rally-teams too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After elasticsearch change, ${ES_TMPDIR} needs quotes around it.
Relates elastic/elasticsearch#39959