Skip to content

Remove Redundant RestoreRequest Class#37535

Merged
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:shorten-restore-service
Jan 17, 2019
Merged

Remove Redundant RestoreRequest Class#37535
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:shorten-restore-service

Conversation

@original-brownbear
Copy link
Copy Markdown
Contributor

* Same as #37464 but for the restore side
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run Gradle build tests 2

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run Gradle build tests 1
Jenkins run Gradle build tests 2

@original-brownbear
Copy link
Copy Markdown
Contributor Author

Jenkins run Gradle build tests 2

@ywelsch ywelsch requested a review from Tim-Brooks January 17, 2019 13:37
Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbrooks8 can you have a look as well?

Copy link
Copy Markdown
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Copy Markdown
Contributor Author

@tbrooks8 @ywelsch thanks!

@original-brownbear original-brownbear merged commit 381d035 into elastic:master Jan 17, 2019
@original-brownbear original-brownbear deleted the shorten-restore-service branch January 17, 2019 21:23
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 17, 2019
…-response-header-performance

* elastic/master:
  Remove Redundant RestoreRequest Class (elastic#37535)
  Create specific exception for when snapshots are in progress (elastic#37550)
  Mute UnicastZenPingTests#testSimplePings
  [DOCS] Adds size limitation to the get datafeeds APIs (elastic#37578)
  Fix assertion at end of forceRefreshes (elastic#37559)
  Propagate Errors in executors to uncaught exception handler (elastic#36137)
  [DOCS] Adds limitation to the get jobs API (elastic#37549)
  Add set_priority action to ILM (elastic#37397)
  Make recovery source send operations non-blocking (elastic#37503)
  Allow field types to optimize phrase prefix queries (elastic#37436)
  Added fatal_exception field for ccr stats in monitoring mapping. (elastic#37563)
  Fix testRelocateWhileContinuouslyIndexingAndWaitingForRefresh (elastic#37560)
  Moved ccr integration to the package with other ccr integration tests.
  Mute TransportClientNodesServiceTests#testListenerFailures
  Decreased time out in test
  Fix erroneous docstrings for abstract bulk by scroll request (elastic#37517)
  SQL: Rename SQL type DATE to DATETIME (elastic#37395)
  Remove the AbstracLifecycleComponent constructor with Settings (elastic#37523)
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this pull request Jan 17, 2019
Commit elastic#37535 removed an internal restore request in favor of the
RestoreSnapshotRequest. Commit elastic#37449 added a new test that used the
internal restore request. This commit modifies the new test to use the
RestoreSnapshotRequest.
original-brownbear added a commit that referenced this pull request Jan 28, 2019
* Same as #37464 but for the restore side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants