Add set_priority action to ILM#37397
Merged
jakelandis merged 9 commits intoelastic:masterfrom Jan 17, 2019
Merged
Conversation
This commit adds a set_priority action to the hot, warm, and cold phases for an ILM policy. This action sets the `index.priority` on the managed index to allow different priorities between the hot, warm, and cold recoveries. This commit also includes the HLRC and documentation changes. closes elastic#36905
Collaborator
|
Pinging @elastic/es-core-features |
dakrone
requested changes
Jan 14, 2019
Member
dakrone
left a comment
There was a problem hiding this comment.
Thanks for opening this @jakelandis, I left some comments
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java
Show resolved
Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...n/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityActionTests.java
Show resolved
Hide resolved
...-node/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
Show resolved
Hide resolved
AthenaEryma
suggested changes
Jan 14, 2019
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java
Outdated
Show resolved
Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java
Outdated
Show resolved
Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java
Show resolved
Hide resolved
Contributor
Author
dakrone
approved these changes
Jan 15, 2019
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left 3 minor comments
...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java
Show resolved
Hide resolved
...n/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityActionTests.java
Outdated
Show resolved
Hide resolved
AthenaEryma
approved these changes
Jan 15, 2019
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM to me as well, once Lee's remaining comments are addressed and CI is happy.
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine run gradle build tests 1 |
Contributor
Author
|
@elasticmachine run gradle build tests 1 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 17, 2019
…-response-header-performance * elastic/master: Remove Redundant RestoreRequest Class (elastic#37535) Create specific exception for when snapshots are in progress (elastic#37550) Mute UnicastZenPingTests#testSimplePings [DOCS] Adds size limitation to the get datafeeds APIs (elastic#37578) Fix assertion at end of forceRefreshes (elastic#37559) Propagate Errors in executors to uncaught exception handler (elastic#36137) [DOCS] Adds limitation to the get jobs API (elastic#37549) Add set_priority action to ILM (elastic#37397) Make recovery source send operations non-blocking (elastic#37503) Allow field types to optimize phrase prefix queries (elastic#37436) Added fatal_exception field for ccr stats in monitoring mapping. (elastic#37563) Fix testRelocateWhileContinuouslyIndexingAndWaitingForRefresh (elastic#37560) Moved ccr integration to the package with other ccr integration tests. Mute TransportClientNodesServiceTests#testListenerFailures Decreased time out in test Fix erroneous docstrings for abstract bulk by scroll request (elastic#37517) SQL: Rename SQL type DATE to DATETIME (elastic#37395) Remove the AbstracLifecycleComponent constructor with Settings (elastic#37523)
jakelandis
added a commit
that referenced
this pull request
Jan 17, 2019
This commit adds a set_priority action to the hot, warm, and cold phases for an ILM policy. This action sets the `index.priority` on the managed index to allow different priorities between the hot, warm, and cold recoveries. This commit also includes the HLRC and documentation changes. closes #36905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a set_priority action to the hot, warm, and cold
phases for an ILM policy. This action sets the
index.priorityon the managed index to allow different priorities between the
hot, warm, and cold recoveries.
This commit also includes the HLRC and documentation changes.
closes #36905