SQL: documentation improvements and updates#36918
Merged
astefan merged 4 commits intoelastic:masterfrom Dec 21, 2018
Merged
Conversation
* Made the aggregations page follow the common template for functions * Modified all tables to have the first row's cells content centered * Polishing in other various sections
Collaborator
|
Pinging @elastic/es-search |
matriv
approved these changes
Dec 21, 2018
Contributor
matriv
left a comment
There was a problem hiding this comment.
LGTM. Nice work on making the docs consistent and making the start for a limitations page!
Left some comments mostly about phrasing.
| include-tagged::{sql-specs}/docs.csv-spec[curTsFunctionPrecision] | ||
| -------------------------------------------------- | ||
|
|
||
| Typically this function is used for relative date/time filtering: |
Contributor
There was a problem hiding this comment.
I would keep this also here for current_timestamp
| === Nested fields in `SYS COLUMNS` and `DESCRIBE TABLE` | ||
|
|
||
| {es} has a special type of relationship fields called `nested` fields. In {es-sql} they can be used by referencing their inner | ||
| sub-fields. These being said, though, `SYS COLUMNS` and `DESCRIBE TABLE` will still display them having the type `NESTED` |
Contributor
There was a problem hiding this comment.
I would change that to: Even though SYS_COLUMNS and..., they cannot be used...
| [float] | ||
| === Multi-nested fields | ||
|
|
||
| {es-sql} doesn't support multi-nested documents. This refers to queries that make reference to more than one nested field in an index. |
Contributor
There was a problem hiding this comment.
I would rephrase: ... multi-nested documents, so a query cannot reference more than one ...
| [float] | ||
| === Paginating nested inner hits | ||
|
|
||
| When SELECTing a nested field, pagination will not work as expected {es-sql} returning __at least__ the page size records. This is like |
Contributor
There was a problem hiding this comment.
...expected, {es-sql} will return...
Contributor
There was a problem hiding this comment.
Also: This is because of the way...
…o docs_improvements
jasontedor
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Dec 21, 2018
* elastic/master: (539 commits) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release Enable IPv6 URIs in reindex from remote (elastic#36874) Watcher: Remove unused local variable in doExecute (elastic#36655) [DOCS] Synchs titles of X-Pack APIs ...
astefan
added a commit
that referenced
this pull request
Dec 21, 2018
* Added Limitations page * Made the aggregations page follow the common template for functions * Modified all tables to have the first row's cells content centered * Polishing in other various sections (cherry picked from commit 09fa827)
astefan
added a commit
that referenced
this pull request
Dec 21, 2018
* Added Limitations page * Made the aggregations page follow the common template for functions * Modified all tables to have the first row's cells content centered * Polishing in other various sections (cherry picked from commit 09fa827)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 21, 2018
* master: (31 commits) Move ingest-geoip default databases out of config (elastic#36949) [ILM][DOCS] add extra scenario to policy update docs (elastic#36871) [Painless] Add String Casting Tests (elastic#36945) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headeroption was ignored and all tables that had the cells content centered for the header row were actually not working as expected.