[DOCS] Merges list of discovery and cluster formation settings#36909
Merged
lcawl merged 7 commits intoelastic:masterfrom Dec 21, 2018
Merged
[DOCS] Merges list of discovery and cluster formation settings#36909lcawl merged 7 commits intoelastic:masterfrom
lcawl merged 7 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
reviewed
Dec 21, 2018
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Great, thanks. I left a few ideas.
| This list is limited in size by the `cluster.max_voting_config_exclusions` | ||
| setting, which defaults to `10`. See <<modules-discovery-settings>>. | ||
|
|
||
| Since voting configuration exclusions are persistent and limited in number, they |
Member
There was a problem hiding this comment.
I think it makes sense to join the previous paragraph to this one.
| configuration file when starting up a master-eligible node. Once the cluster | ||
| has formed this setting is no longer required and is ignored. It need not be set | ||
| The initial set of master-eligible nodes is defined in the | ||
| <<modules-discovery-settings,`cluster.initial_master_nodes` setting>>. When you |
Member
There was a problem hiding this comment.
I think it would be friendlier to link to the "important settings" page here, i.e. <<initial_master_nodes>>.
| desirable to add or remove some master-eligible nodes to or from a cluster. | ||
|
|
||
| ==== Adding master-eligible nodes | ||
| ==== Adding nodes |
Member
There was a problem hiding this comment.
You're absolutely right that the words in this section apply to master-ineligible nodes too, and we can therefore remove the master-eligible in the next line as well.
However if we make this change then it becomes obvious that we are missing documentation about removing master-ineligible nodes. Perhaps this is the right place to write about that too, but that needs some thought. I would prefer not to make this change now and to follow-up later.
|
|
||
| During master election or when joining an existing formed cluster, a node | ||
| sends a join request to the master in order to be officially added to the | ||
| cluster. You can use the `cluster.join.timeout` setting to configure how long a |
Member
There was a problem hiding this comment.
Could we mention the default (30s) in this paragraph?
Contributor
Author
|
Thanks @DaveCTurner I've implemented the changes and refreshed the preview |
DaveCTurner
approved these changes
Dec 21, 2018
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Great, LGTM. One whitespace nit.
| sends a join request to the master in order to be officially added to the | ||
| cluster. You can use the `cluster.join.timeout` setting to configure how long a | ||
| node waits after sending a request to join a cluster. Its default value is `30s` | ||
| . See <<modules-discovery-settings>>. |
Member
There was a problem hiding this comment.
Nit: the period at the start of this line should be at the end of the previous.
jasontedor
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Dec 21, 2018
* elastic/master: (539 commits) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release Enable IPv6 URIs in reindex from remote (elastic#36874) Watcher: Remove unused local variable in doExecute (elastic#36655) [DOCS] Synchs titles of X-Pack APIs ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 21, 2018
* master: (31 commits) Move ingest-geoip default databases out of config (elastic#36949) [ILM][DOCS] add extra scenario to policy update docs (elastic#36871) [Painless] Add String Casting Tests (elastic#36945) SQL: documentation improvements and updates (elastic#36918) [DOCS] Merges list of discovery and cluster formation settings (elastic#36909) Only compress responses if request was compressed (elastic#36867) Remove duplicate paragraph (elastic#36942) Fix URI to cluster stats endpoint on specific nodes (elastic#36784) Fix typo in unitTest task (elastic#36930) RecoveryMonitor#lastSeenAccessTime should be volatile (elastic#36781) [CCR] Add `ccr.auto_follow_coordinator.wait_for_timeout` setting (elastic#36714) Scripting: Remove deprecated params.ctx (elastic#36848) Refactor the REST actions to clarify what endpoints are deprecated. (elastic#36869) Add JDK 12 to CI rotation (elastic#36915) Improve error message for 6.x style realm settings (elastic#36876) Send clear session as routable remote request (elastic#36805) [DOCS] Remove redundant ILM attributes (elastic#36808) SQL: Fix bug regarding histograms usage in scripting (elastic#36866) Update index mappings when ccr restore complete (elastic#36879) Docs: Bump version to alpha2 after release ...
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #34714
In particular, https://github.com/elastic/elasticsearch/pull/34714/files#r243245830
This PR compiles the lists of settings related to discovery and cluster formation in a single page.