[Zen2] Respect the no_master_block setting#36478
Merged
DaveCTurner merged 1 commit intoelastic:masterfrom Dec 11, 2018
Merged
Conversation
Today the Zen2 coordinator only applies a write block when there is no known elected master, ignoring the `discovery.zen.no_master_block` setting. This commit resolves this, applying the correct block according to the configuration instead.
Collaborator
|
Pinging @elastic/es-distributed |
61 tasks
ywelsch
approved these changes
Dec 11, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
I was wondering if we should get rid of DiscoverySettings. In that case, it would be better to just extract the NO_MASTER_BLOCK stuff directly into Coordinator. Can you now also enable NoMasterNodeIT as well as testVerifyApiBlocksDuringPartition()?
Member
Author
|
I will follow up with changes to the ITs. I contemplated removing |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 11, 2018
This change follows up on elastic#36478 by migrating the affected integration tests to use Zen2.
jasontedor
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 11, 2018
* elastic/master: (36 commits) Add check for minimum required Docker version (elastic#36497) Minor search controller changes (elastic#36479) Add default methods to DocValueFormat (elastic#36480) Fix the mixed cluster REST test explain/11_basic_with_types. Modify `BigArrays` to take name of circuit breaker (elastic#36461) Move LoggedExec to minimumRuntime source set (elastic#36453) added 6.5.4 version Add test logging for elastic#35644 Tests- added helper methods to ESRestTestCase for checking warnings (elastic#36443) SQL: move requests' parameters to requests JSON body (elastic#36149) [Zen2] Respect the no_master_block setting (elastic#36478) Require soft-deletes when access changes snapshot (elastic#36446) Switch more tests to zen2 (elastic#36367) [Painless] Add extensive tests for def to primitive casts (elastic#36455) Add setting to bypass Rollover action (elastic#36235) Try running CI against Zulu (elastic#36391) [DOCS] Reworked the shard allocation filtering info. (elastic#36456) Log [initial_master_nodes] on formation failure (elastic#36466) converting ForbiddenPatternsTask to .java (elastic#36194) fixed typo ...
DaveCTurner
added a commit
that referenced
this pull request
Dec 12, 2018
This change follows up on #36478 by migrating the affected integration tests to use Zen2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the Zen2 coordinator only applies a write block when there is no known
elected master, ignoring the
discovery.zen.no_master_blocksetting. Thiscommit resolves this, applying the correct block according to the configuration
instead.