converting ForbiddenPatternsTask to .java#36194
Merged
alpar-t merged 15 commits intoelastic:masterfrom Dec 11, 2018
cdschneider:replace-groovy-forbidden-task
Merged
converting ForbiddenPatternsTask to .java#36194alpar-t merged 15 commits intoelastic:masterfrom cdschneider:replace-groovy-forbidden-task
alpar-t merged 15 commits intoelastic:masterfrom
cdschneider:replace-groovy-forbidden-task
Conversation
Collaborator
|
Pinging @elastic/es-core-infra |
alpar-t
reviewed
Dec 4, 2018
Contributor
alpar-t
left a comment
There was a problem hiding this comment.
Thanks for you contribution @cdschneider !
I left a few minor comments.
Some of them were already there in the Groovy code but I think this is a good opportunity to take care of them.
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java
Outdated
Show resolved
Hide resolved
buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java
Outdated
Show resolved
Hide resolved
buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine test this please |
…groovy-forbidden-task
Contributor
|
@elasticmachine test this please |
added 7 commits
December 5, 2018 20:23
…t to assert file marker name = task name
alpar-t
reviewed
Dec 6, 2018
Contributor
There was a problem hiding this comment.
Thanks @cdschneider ! We're almost there, I left just a few comments for small things.
buildSrc/src/main/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTask.java
Outdated
Show resolved
Hide resolved
| .stream() | ||
| .map(sourceSet -> sourceSet.getAllSource().matching(filesFilter)) | ||
| .reduce(FileTree::plus) | ||
| .orElse(getProject().files().getAsFileTree()); |
Contributor
There was a problem hiding this comment.
getProject().files() returns a file collection, no need for getAsFileTree
Contributor
Author
There was a problem hiding this comment.
Because the result of reduce() is an Optional<FileTree>, doesn't the result of the .orElse() statement also need be of type FileTree?
buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
There are non UTF-8 files in other projects too it seems. Might be worth to catch the exception and wrap it to include the offending file in the error message. You'll be able to fond them all by running |
Contributor
|
@elasticmachine test this please |
31 tasks
Contributor
|
@elasticmachine test this please |
Contributor
|
Thanks again for your contribution @cdschneider, we really appreciate it! |
alpar-t
pushed a commit
that referenced
this pull request
Dec 11, 2018
* converting ForbiddenPatternsTask to java impl & unit tests
Contributor
Author
|
No problem! Glad I could help! 😄 I will definitely be trying to contributie again soon! |
jasontedor
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 11, 2018
* elastic/master: (36 commits) Add check for minimum required Docker version (elastic#36497) Minor search controller changes (elastic#36479) Add default methods to DocValueFormat (elastic#36480) Fix the mixed cluster REST test explain/11_basic_with_types. Modify `BigArrays` to take name of circuit breaker (elastic#36461) Move LoggedExec to minimumRuntime source set (elastic#36453) added 6.5.4 version Add test logging for elastic#35644 Tests- added helper methods to ESRestTestCase for checking warnings (elastic#36443) SQL: move requests' parameters to requests JSON body (elastic#36149) [Zen2] Respect the no_master_block setting (elastic#36478) Require soft-deletes when access changes snapshot (elastic#36446) Switch more tests to zen2 (elastic#36367) [Painless] Add extensive tests for def to primitive casts (elastic#36455) Add setting to bypass Rollover action (elastic#36235) Try running CI against Zulu (elastic#36391) [DOCS] Reworked the shard allocation filtering info. (elastic#36456) Log [initial_master_nodes] on formation failure (elastic#36466) converting ForbiddenPatternsTask to .java (elastic#36194) fixed typo ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a part of #34459 specifically
ForbiddenPatternsTask