Fix deprecation of audit log settings#36175
Merged
albertzaharovits merged 3 commits intoelastic:6.xfrom Dec 3, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-security |
jaymode
approved these changes
Dec 3, 2018
Member
jaymode
left a comment
There was a problem hiding this comment.
I left a couple of small comments. Otherwise LGTM
| settingsBuilder.put("xpack.security.audit.outputs", "logfile"); | ||
| // add only startup filter policies | ||
| settingsBuilder.put(startupFilterSettings); | ||
| // we cannot test deprecated variants of these settings because they are overriden |
Member
There was a problem hiding this comment.
I think this comment is confusing. Maybe say "Remove non-deprecated version of prefix settings so that we can test the deprecated variant" ?
| updateSettings(settingsBuilder.build(), persistent); | ||
| assertThat(loggingAuditTrail.entryCommonFields.commonFields.containsKey(LoggingAuditTrail.NODE_NAME_FIELD_NAME), is(false)); | ||
| assertThat(loggingAuditTrail.entryCommonFields.commonFields.containsKey(LoggingAuditTrail.HOST_ADDRESS_FIELD_NAME), is(false)); | ||
| assertThat(loggingAuditTrail.entryCommonFields.commonFields.containsKey(LoggingAuditTrail.HOST_NAME_FIELD_NAME), is(false)); |
Member
There was a problem hiding this comment.
just to be a bit paranoid, can you set them back to true and verify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have botched deprecating the "prefix" logfile audit settings in #34475 , by not registering them.
This commit fixes this, and adds a test that these deprecated settings still work and are dynamic.
Closes #36162