Rename and deprecated prefix logfile audit setting names#34475
Merged
albertzaharovits merged 2 commits intoelastic:masterfrom Oct 18, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-security |
jaymode
approved these changes
Oct 16, 2018
Member
jaymode
left a comment
There was a problem hiding this comment.
The changes LGTM. When you backport we need to document the deprecation of these settings in the migrate_6_5.asciidoc file. Also, please open a followup PR that removes the deprecated settings from master and documents the removal as a breaking change for 7.0
albertzaharovits
added a commit
that referenced
this pull request
Oct 18, 2018
The logfile audit log format is no longer formed by prefix fields followed by key value fields, it is all formed by key value fields only (JSON format). Consequently, the following settings, which toggled some of the prefix fields, have been renamed by splicing out the prefix component: - xpack.security.audit.logfile.prefix.emit_node_host_address - xpack.security.audit.logfile.prefix.emit_node_host_name - xpack.security.audit.logfile.prefix.emit_node_name
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
The logfile audit log format is no longer formed by prefix fields followed by key value fields, it is all formed by key value fields only (JSON format). Consequently, the following settings, which toggled some of the prefix fields, have been renamed: audit.logfile .prefix.emit_node_host_address audit.logfile .prefix.emit_node_host_name audit.logfile .prefix.emit_node_name
albertzaharovits
added a commit
that referenced
this pull request
Dec 3, 2018
albertzaharovits
added a commit
that referenced
this pull request
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31931 Changed the format of the logfile audit log.
It is no longer formed by prefix fields followed by key value fields, it is all formed by key value fields only (JSON format).
Consequently, the following settings, which toggled some of the prefix fields, should be renamed:
audit.logfile
.prefix.emit_node_host_addressaudit.logfile
.prefix.emit_node_host_nameaudit.logfile
.prefix.emit_node_nameThe prefix variants have been deprecated (in 7.0 also?) in favor of the variants lacking the prefix. .
The setting
audit.logfile.prefix.emit_node_idwhich has not seen the release light has simply been renamed toaudit.logfile.emit_node_id.Relates #31931 (should have been considered there).