Fix LineLength Check Suppressions: index.fielddata#34891
Merged
original-brownbear merged 5 commits intoelastic:masterfrom Oct 26, 2018
original-brownbear:fielddata-line-lengths
Merged
Fix LineLength Check Suppressions: index.fielddata#34891original-brownbear merged 5 commits intoelastic:masterfrom original-brownbear:fielddata-line-lengths
original-brownbear merged 5 commits intoelastic:masterfrom
original-brownbear:fielddata-line-lengths
Conversation
Contributor
original-brownbear
commented
Oct 25, 2018
- Fix linelength suppressions in index.fielddata
- Some lines that were too long were dead code => Removed them and all code that became dead because of it
- Relates Remove checkstyle line length suppressions #34884
* Fix linelength suppressions in index.fielddata * Some lines that were too long were dead code => Removed them and all code that became dead because of it * Relates #34884
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
approved these changes
Oct 25, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
I left a baker's dozen requests to add a single extra level of indentation.
| @SuppressWarnings("unchecked") | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader, IFD indexFieldData) throws Exception { | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(DirectoryReader indexReader, | ||
| IFD indexFieldData) throws Exception { |
Member
There was a problem hiding this comment.
Could you indent this one more time so the method declaration doesn't line up with the method body?
|
|
||
| public DoubleValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) { | ||
| public DoubleValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, | ||
| Nested nested) { |
Member
There was a problem hiding this comment.
Could you indent this one more time so the method declaration doesn't line up with the method body?
|
|
||
| public FloatValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) { | ||
| public FloatValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, | ||
| Nested nested) { |
|
|
||
| public LongValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, Nested nested) { | ||
| public LongValuesComparatorSource(IndexNumericFieldData indexFieldData, @Nullable Object missingValue, MultiValueMode sortMode, | ||
| Nested nested) { |
|
|
||
| public static IndexOrdinalsFieldData buildEmpty(IndexSettings indexSettings, final IndexReader indexReader, IndexOrdinalsFieldData indexFieldData) throws IOException { | ||
| public static IndexOrdinalsFieldData buildEmpty(IndexSettings indexSettings, final IndexReader indexReader, | ||
| IndexOrdinalsFieldData indexFieldData) throws IOException { |
| @Override | ||
| public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested, boolean reverse) { | ||
| public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested, | ||
| boolean reverse) { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the method body?
| @Override | ||
| public IndexOrdinalsFieldData build(IndexSettings indexSettings, MappedFieldType fieldType, | ||
| IndexFieldDataCache cache, CircuitBreakerService breakerService, MapperService mapperService) { | ||
| IndexFieldDataCache cache, CircuitBreakerService breakerService, MapperService mapperService) { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the method body?
| @Override | ||
| public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested, boolean reverse) { | ||
| public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested, | ||
| boolean reverse) { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the method body?
| @Override | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData<FD>> FD load(final LeafReaderContext context, final IFD indexFieldData) throws Exception { | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData<FD>> FD load(final LeafReaderContext context, | ||
| final IFD indexFieldData) throws Exception { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the method body?
| @Override | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(final DirectoryReader indexReader, final IFD indexFieldData) throws Exception { | ||
| public <FD extends AtomicFieldData, IFD extends IndexFieldData.Global<FD>> IFD load(final DirectoryReader indexReader, | ||
| final IFD indexFieldData) throws Exception { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the method body?
Contributor
Author
|
@nik9000 thanks! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* 'master' of github.com:elastic/elasticsearch: Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519) [CCR] Retry when no index shard stats can be found (elastic#34852) [Docs] audit logfile structured format (elastic#34584) [Test] Fix FullClusterRestartIT.testShrink() with copy_settings param (elastic#34853) Fix LineLength Check Suppressions: index.fielddata (elastic#34891) TEST: Stablize Minio Free Port Search (elastic#34894) Delete flaky SettingsBasedHostProviderIT test (elastic#34813) [ML] Include message in field_stats for text log files (elastic#34861) [TEST] HLRC: Expand failure messages in API checks (elastic#34838) Lowercase static final DeprecationLogger instance names (elastic#34887)
original-brownbear
added a commit
that referenced
this pull request
Oct 27, 2018
33 tasks
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Fix linelength suppressions in index.fielddata * Some lines that were too long were dead code => Removed them and all code that became dead because of it * Relates #34884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.