[Style] Fix line lengths in action.admin.indices#34890
Merged
AthenaEryma merged 4 commits intoelastic:masterfrom Oct 26, 2018
Merged
[Style] Fix line lengths in action.admin.indices#34890AthenaEryma merged 4 commits intoelastic:masterfrom
AthenaEryma merged 4 commits intoelastic:masterfrom
Conversation
Clean up lines over 140 characters in the the `org.elasticsearch.action.admin.indices` packages
Collaborator
|
Pinging @elastic/es-core-infra |
33 tasks
nik9000
approved these changes
Oct 25, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
LGTM except for 24 place I'd like you to hit tab one extra time so the class body doesn't mix in with the class declaration.
|
|
||
| public class ClearIndicesCacheRequestBuilder extends BroadcastOperationRequestBuilder<ClearIndicesCacheRequest, ClearIndicesCacheResponse, ClearIndicesCacheRequestBuilder> { | ||
| public class ClearIndicesCacheRequestBuilder | ||
| extends BroadcastOperationRequestBuilder<ClearIndicesCacheRequest, ClearIndicesCacheResponse, ClearIndicesCacheRequestBuilder> { |
Member
There was a problem hiding this comment.
Could you indent this one more time so it doesn't line up with the class body?
...r/src/main/java/org/elasticsearch/action/admin/indices/delete/DeleteIndexRequestBuilder.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class IndicesExistsRequestBuilder extends MasterNodeReadOperationRequestBuilder<IndicesExistsRequest, IndicesExistsResponse, IndicesExistsRequestBuilder> { | ||
| public class IndicesExistsRequestBuilder | ||
| extends MasterNodeReadOperationRequestBuilder<IndicesExistsRequest, IndicesExistsResponse, IndicesExistsRequestBuilder> { |
| @Deprecated | ||
| public class TypesExistsRequestBuilder extends MasterNodeReadOperationRequestBuilder<TypesExistsRequest, TypesExistsResponse, TypesExistsRequestBuilder> { | ||
| public class TypesExistsRequestBuilder | ||
| extends MasterNodeReadOperationRequestBuilder<TypesExistsRequest, TypesExistsResponse, TypesExistsRequestBuilder> { |
| */ | ||
| public class TransportFlushAction extends TransportBroadcastReplicationAction<FlushRequest, FlushResponse, ShardFlushRequest, ReplicationResponse> { | ||
| public class TransportFlushAction | ||
| extends TransportBroadcastReplicationAction<FlushRequest, FlushResponse, ShardFlushRequest, ReplicationResponse> { |
| */ | ||
| public class TransportDeleteIndexTemplateAction extends TransportMasterNodeAction<DeleteIndexTemplateRequest, AcknowledgedResponse> { | ||
| public class TransportDeleteIndexTemplateAction | ||
| extends TransportMasterNodeAction<DeleteIndexTemplateRequest, AcknowledgedResponse> { |
|
|
||
| public class GetIndexTemplatesRequestBuilder extends MasterNodeReadOperationRequestBuilder<GetIndexTemplatesRequest, GetIndexTemplatesResponse, GetIndexTemplatesRequestBuilder> { | ||
| public class GetIndexTemplatesRequestBuilder | ||
| extends MasterNodeReadOperationRequestBuilder<GetIndexTemplatesRequest, GetIndexTemplatesResponse, GetIndexTemplatesRequestBuilder> { |
Contributor
Author
There was a problem hiding this comment.
I broke this one out onto separate lines because an extra tab makes it go over 140.
|
|
||
| public class UpgradeStatusRequestBuilder extends BroadcastOperationRequestBuilder<UpgradeStatusRequest, UpgradeStatusResponse, UpgradeStatusRequestBuilder> { | ||
| public class UpgradeStatusRequestBuilder | ||
| extends BroadcastOperationRequestBuilder<UpgradeStatusRequest, UpgradeStatusResponse, UpgradeStatusRequestBuilder> { |
| */ | ||
| public class UpgradeSettingsRequestBuilder extends AcknowledgedRequestBuilder<UpgradeSettingsRequest, AcknowledgedResponse, UpgradeSettingsRequestBuilder> { | ||
| public class UpgradeSettingsRequestBuilder | ||
| extends AcknowledgedRequestBuilder<UpgradeSettingsRequest, AcknowledgedResponse, UpgradeSettingsRequestBuilder> { |
|
|
||
| public class TransportValidateQueryAction extends TransportBroadcastAction<ValidateQueryRequest, ValidateQueryResponse, ShardValidateQueryRequest, ShardValidateQueryResponse> { | ||
| public class TransportValidateQueryAction | ||
| extends TransportBroadcastAction<ValidateQueryRequest, ValidateQueryResponse, ShardValidateQueryRequest, ShardValidateQueryResponse> { |
Contributor
Author
There was a problem hiding this comment.
I broke this one out onto separate lines because an extra tab makes it go over 140.
Contributor
Author
|
I messed up the commit message on the backport and left out the PR number so it didn't get linked here, the backport of this is e30bee7 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* 'master' of github.com:elastic/elasticsearch: Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519) [CCR] Retry when no index shard stats can be found (elastic#34852) [Docs] audit logfile structured format (elastic#34584) [Test] Fix FullClusterRestartIT.testShrink() with copy_settings param (elastic#34853) Fix LineLength Check Suppressions: index.fielddata (elastic#34891) TEST: Stablize Minio Free Port Search (elastic#34894) Delete flaky SettingsBasedHostProviderIT test (elastic#34813) [ML] Include message in field_stats for text log files (elastic#34861) [TEST] HLRC: Expand failure messages in API checks (elastic#34838) Lowercase static final DeprecationLogger instance names (elastic#34887)
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: Introduce cross-cluster replication API docs (elastic#34726) Responses can use Writeable.Reader interface (elastic#34655) SQL: Provide null-safe scripts for Not and Neg (elastic#34877) Fix put/resume follow request parsing (elastic#34913) Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Clean up lines over 140 characters in the the `org.elasticsearch.action.admin.indices` packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up lines over 140 characters in the the
org.elasticsearch.action.admin.indicespackagesRelates to #34884