fix query string example for boolean query#28881
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
hi @fbaligand thanks for sending a PR. I think that the example is correct as-is though. |
|
Hi @javanna, Why I really think it is a mistake :
|
|
heya @fbaligand thanks for clarifying, I am reopening this. I still think that city was meant to be part of the query, yet even in that case the explanation and the parentheses would need to be fixed. @jimczi given that you added this example a while ago, what do you think? |
|
Thanks for reopening the issue ! Concerning ‘city’, for having tested it on Elasticsearch 6.2.1, a document with « Boston City » will match, which is not the aim. |
|
@jimczi |
|
Sorry for the late reply @fbaligand . |
|
Hi @jimczi Thanks for your answer. |
|
Sorry but I think that this example is fine, the important block of this example is that |
|
Hi @jimczi OK, no problem. So I finally only removed last parenthesis. |
|
Sorry for the late response, I merged your pr in master. Thanks @fbaligand ! |
|
Thanks @jimczi for the merge ! |
* master: (80 commits) Remove HTTP max content length leniency (elastic#29337) Begin moving XContent to a separate lib/artifact (elastic#29300) Java versions for ci (elastic#29320) Minor cleanup in the InternalEngine (elastic#29241) Clarify expectations of false positives/negatives (elastic#27964) Update docs on vertex ordering (elastic#27963) Revert "REST high-level client: add support for Indices Update Settings API (elastic#28892)" (elastic#29323) [test] remove Streamable serde assertions (elastic#29307) Improve query string docs (elastic#28882) fix query string example for boolean query (elastic#28881) Resolve unchecked cast warnings introduced with elastic#28892 REST high-level client: add support for Indices Update Settings API (elastic#28892) Search: Validate script query is run with a single script (elastic#29304) [DOCS] Added info on WGS-84. Closes issue elastic#3590 (elastic#29305) Increase timeout on Netty client latch for tests Build: Use branch specific refspec sysprop for bwc builds (elastic#29299) TEST: trim unsafe commits before opening engine Move trimming unsafe commits from engine ctor to store (elastic#29260) Fix incorrect geohash for lat 90, lon 180 (elastic#29256) Do not load global state when deleting a snapshot (elastic#29278) ...
Replace
(ny OR (new AND york)) city)bycity:(ny OR (new AND york))