Detect mktemp from coreutils#27659
Merged
jasontedor merged 1 commit intoelastic:masterfrom Dec 5, 2017
Merged
Conversation
GNU mktemp and BSD mktemp have different command line flags. On some macOS systems users have mktemp from coreutils in their PATH overriding the system mktemp from BSD. This commit adds detection for the coreutils mktemp versus the BSD mktemp and uses the appropriate syntax based on the detection.
jasontedor
added a commit
that referenced
this pull request
Dec 5, 2017
GNU mktemp and BSD mktemp have different command line flags. On some macOS systems users have mktemp from coreutils in their PATH overriding the system mktemp from BSD. This commit adds detection for the coreutils mktemp versus the BSD mktemp and uses the appropriate syntax based on the detection. Relates #27659
Member
Author
|
Thanks for your help with this one @dakrone. |
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Dec 8, 2017
When using mktemp from coreutils there was an 's' missing from elasticsearch. Follow-up for elastic#27659
droberts195
added a commit
that referenced
this pull request
Dec 8, 2017
When using mktemp from coreutils there was an 's' missing from elasticsearch. Follow-up for #27659
droberts195
added a commit
that referenced
this pull request
Dec 8, 2017
When using mktemp from coreutils there was an 's' missing from elasticsearch. Follow-up for #27659
|
Could it also include supports for alpine linux (to reduce the docker image size)? There is no "coreutils" in busybox msg. $ mktemp --help Usage: mktemp [-dt] [-p DIR] [TEMPLATE] Create a temporary file with name based on TEMPLATE and print its name. Base directory is: -p DIR, else $TMPDIR, else /tmp |
Member
Author
|
@plmnko You can set |
This was referenced Feb 20, 2018
pires
pushed a commit
to pires/docker-elasticsearch
that referenced
this pull request
Feb 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU mktemp and BSD mktemp have different command line flags. On some macOS systems users have mktemp from coreutils in their PATH overriding the system mktemp from BSD. This commit adds detection for the coreutils mktemp versus the BSD mktemp and uses the appropriate syntax based on the detection.
Relates #27609, relates #27643