Platform independent mktemp#27643
Closed
albertzaharovits wants to merge 1 commit intoelastic:masterfrom
Closed
Conversation
Member
|
Thanks @albertzaharovits, but I would prefer to not have to reason about a one-liner that could be invoking a different command depending on the OS. I do not want to have to reason about well it could be this one, or it could be that one, and I also do not want to have to maintain something like this. I think a clearer solution is to detect when we are relying on BSD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate platform independent temp directory using an explicit template instead of branching on the platform. (branching can fail if you use
coreutilsonDarwin)on macOS:
on linux (coreutils):
All hail StackOverflow