Scripting: Deprecate scripts.max_compilation_per_minute setting#26420
Merged
spinscale merged 1 commit intoelastic:5.6from Aug 29, 2017
Merged
Conversation
This setting will be replaced with script.max_compilation_rate in Elasticsearch 6.0, thus it can be marked as deprecated in 5.6. The REST tests that delete a setting, ensure that this setting exists before, as otherwise a bug is hit, that the required header is not returned (see elastic#26419).
jasontedor
added a commit
that referenced
this pull request
Aug 29, 2017
* 5.6: Adapt Netty 3 to avoid blocking on channel close Avoid blocking on channel close on network thread (#25521) Scripting: Deprecate scripts.max_compilation_per_minute setting (#26420) Revert "[Docs] Update Java Low-Level documentation to reflect shaded deps (#25882)" [DOCS] Updates 5.6.0 release notes [DOCS] Updates 5.5.3 release notes Revert "Scripting: Deprecate scripts.max_compilation_per_minute setting (#26402)" Scripting: Deprecate scripts.max_compilation_per_minute setting (#26402)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting will be replaced with script.max_compilation_rate in
Elasticsearch 6.0, thus it can be marked as deprecated in 5.6.
The REST tests that delete a setting, ensure that this setting exists
before, as otherwise a bug is hit, that the required header is not
returned (see #26419).
Note: This is just an extension of #26402 with fixed tests.