Scripting: Deprecate scripts.max_compilation_per_minute setting#26402
Conversation
This setting will be replaced with script.max_compilation_rate in Elasticsearch 6.0, thus it can be marked as deprecated in 5.6.
|
I'm surprised the changes aren't larger than this? We set the setting in internal test cluster and REST tests, I expect un-acknowledged warnings to fail the build? |
| Setting.intSetting("script.max_size_in_bytes", 65535, Property.NodeScope); | ||
| public static final Setting<Integer> SCRIPT_MAX_COMPILATIONS_PER_MINUTE = | ||
| Setting.intSetting("script.max_compilations_per_minute", 15, 0, Property.Dynamic, Property.NodeScope); | ||
| Setting.intSetting("script.max_compilations_per_minute", 15, 0, Property.Dynamic, Property.NodeScope, Property.Deprecated); |
There was a problem hiding this comment.
I don't feel like we should deprecate this unless there's an actual replacement. It feels strange to say "don't use this setting, but you can't replace it until 6.0".
I think we should port the max_compilation_rate changes to 5.6 so that a user can swap the settings from deprecated to non-deprecated without upgrading
There was a problem hiding this comment.
We do this sometimes (e.g., default paths), it's okay.
There was a problem hiding this comment.
We discussed this and decided documenting it is fine.
|
I reverted this due to test failures, that are dependent on the order of the tests run in the |
* 5.6: Adapt Netty 3 to avoid blocking on channel close Avoid blocking on channel close on network thread (#25521) Scripting: Deprecate scripts.max_compilation_per_minute setting (#26420) Revert "[Docs] Update Java Low-Level documentation to reflect shaded deps (#25882)" [DOCS] Updates 5.6.0 release notes [DOCS] Updates 5.5.3 release notes Revert "Scripting: Deprecate scripts.max_compilation_per_minute setting (#26402)" Scripting: Deprecate scripts.max_compilation_per_minute setting (#26402)
This setting will be replaced with script.max_compilation_rate in
Elasticsearch 6.0, thus it can be marked as deprecated in 5.6.