Settings: Disallow secure setting to exist in normal settings#23976
Merged
rjernst merged 4 commits intoelastic:masterfrom Apr 7, 2017
Merged
Settings: Disallow secure setting to exist in normal settings#23976rjernst merged 4 commits intoelastic:masterfrom
rjernst merged 4 commits intoelastic:masterfrom
Conversation
This commit removes the "legacy" feature of secure settings, which setup a parallel setting that was a fallback in the insecure elasticsearch.yml. This was previously used to allow the new secure setting name to be that of the old setting name, but is now not in use due to other refactorings. It is much cleaner to just have all secure settings use new setting names. If in the future we want to reuse the previous setting name, once support for the insecure settings have been removed, we can then rename the secure setting. This also adds a test for the behavior.
Member
Author
|
Note that before this change, if a setting had |
Contributor
|
looks great! |
rjernst
added a commit
that referenced
this pull request
Apr 7, 2017
This commit removes the "legacy" feature of secure settings, which setup a parallel setting that was a fallback in the insecure elasticsearch.yml. This was previously used to allow the new secure setting name to be that of the old setting name, but is now not in use due to other refactorings. It is much cleaner to just have all secure settings use new setting names. If in the future we want to reuse the previous setting name, once support for the insecure settings have been removed, we can then rename the secure setting. This also adds a test for the behavior.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 8, 2017
* master: Discovery EC2: Remove region setting (elastic#23991) AWS Plugins: Remove signer type setting (elastic#23984) Settings: Disallow secure setting to exist in normal settings (elastic#23976) Add registration of new discovery settings Settings: Migrate ec2 discovery sensitive settings to elasticsearch keystore (elastic#23961) Fix throttled reindex_from_remote (elastic#23953) Add comment why we check for null fetch results during merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the "legacy" feature of secure settings, which setup
a parallel setting that was a fallback in the insecure
elasticsearch.yml. This was previously used to allow the new secure
setting name to be that of the old setting name, but is now not in use
due to other refactorings. It is much cleaner to just have all secure
settings use new setting names. If in the future we want to reuse the
previous setting name, once support for the insecure settings have been
removed, we can then rename the secure setting. This also adds a test
for the behavior.