Settings: Migrate ec2 discovery sensitive settings to elasticsearch keystore#23961
Merged
rjernst merged 1 commit intoelastic:masterfrom Apr 7, 2017
Merged
Settings: Migrate ec2 discovery sensitive settings to elasticsearch keystore#23961rjernst merged 1 commit intoelastic:masterfrom
rjernst merged 1 commit intoelastic:masterfrom
Conversation
…eystore This change adds secure settings for access/secret keys and proxy username/password to ec2 discovery. It adds the new settings with the prefix `discovery.ec2`, copies other relevant ec2 client settings to the same prefix, and deprecates all other settings (`cloud.aws.*` and `cloud.aws.ec2.*`). Note that this is simpler than the client configs in repository-s3 because discovery is only initialized once for the entire node, so there is no reason to complicate the configuration with the ability to have multiple sets of client settings. relates elastic#22475
s1monw
approved these changes
Apr 7, 2017
Contributor
s1monw
left a comment
There was a problem hiding this comment.
LGTM - I have a question, what happens if somebody uses the deprecated setting but not as a secure setting but instead as an ordinary setting? Can we have a tests for this somehow?
Member
Author
rjernst
added a commit
that referenced
this pull request
Apr 7, 2017
…eystore (#23961) This change adds secure settings for access/secret keys and proxy username/password to ec2 discovery. It adds the new settings with the prefix `discovery.ec2`, copies other relevant ec2 client settings to the same prefix, and deprecates all other settings (`cloud.aws.*` and `cloud.aws.ec2.*`). Note that this is simpler than the client configs in repository-s3 because discovery is only initialized once for the entire node, so there is no reason to complicate the configuration with the ability to have multiple sets of client settings. relates #22475
rjernst
added a commit
that referenced
this pull request
Apr 7, 2017
This was forgotten as part of #23961
rjernst
added a commit
that referenced
this pull request
Apr 7, 2017
This was forgotten as part of #23961
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 8, 2017
* master: Discovery EC2: Remove region setting (elastic#23991) AWS Plugins: Remove signer type setting (elastic#23984) Settings: Disallow secure setting to exist in normal settings (elastic#23976) Add registration of new discovery settings Settings: Migrate ec2 discovery sensitive settings to elasticsearch keystore (elastic#23961) Fix throttled reindex_from_remote (elastic#23953) Add comment why we check for null fetch results during merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds secure settings for access/secret keys and proxy
username/password to ec2 discovery. It adds the new settings with the
prefix
discovery.ec2, copies other relevant ec2 client settings to thesame prefix, and deprecates all other settings (
cloud.aws.*andcloud.aws.ec2.*). Note that this is simpler than the client configsin repository-s3 because discovery is only initialized once for the
entire node, so there is no reason to complicate the configuration with
the ability to have multiple sets of client settings.
relates #22475