Tests: Fix reproduce line for packagingTest#23365
Merged
rjernst merged 2 commits intoelastic:masterfrom Feb 25, 2017
Merged
Conversation
This commit fixes the reproduce line output when the vagrant packagingTest fails. Before only the `gradle packagingTest` would be output, but the seed and list of versions was swallowed by groovy with an ancillary failure (due to the `+` being on the wrong line for a string continuation). With the new reproduce line, it is now output next to the task right after failure, contains the actual task (specific to the box that fails), and contains the seed. It also no longer contains the upgrade versions list, as the seed is used to determine which of those to use, and the same file would be read when testing a failure on a particular git commit. Finally, this also ties bats test setup directly to packagingTest, instead of to the vagrant up command.
jasontedor
approved these changes
Feb 25, 2017
Member
jasontedor
left a comment
There was a problem hiding this comment.
It looks right to me, let's get it in (I left one minor nit).
| seed = new BigInteger(masterSeed, 16).longValue() | ||
| formattedSeed = maybeTestsSeed | ||
| if (maybeTestsSeed.trim().isEmpty()) { | ||
| throw new GradleException("explicit -Dtests.seed cannot be empty") |
rjernst
added a commit
that referenced
this pull request
Feb 25, 2017
This commit fixes the reproduce line output when the vagrant packagingTest fails. Before only the `gradle packagingTest` would be output, but the seed and list of versions was swallowed by groovy with an ancillary failure (due to the `+` being on the wrong line for a string continuation). With the new reproduce line, it is now output next to the task right after failure, contains the actual task (specific to the box that fails), and contains the seed. It also no longer contains the upgrade versions list, as the seed is used to determine which of those to use, and the same file would be read when testing a failure on a particular git commit. Finally, this also ties bats test setup directly to packagingTest, instead of to the vagrant up command.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 25, 2017
* master: (26 commits) CLI: Fix prompting for yes/no to handle console returning null (elastic#23320) Tests: Fix reproduce line for packagingTest (elastic#23365) Build: Remove extra copies of netty license (elastic#23361) [TEST] Removes timeout based wait_for_active_shards REST test (elastic#23360) [TEST] increase timeout slightly in wait_for_active_shards test to allow for index creation cluster state update to be processed before ensuring the wait times out Handle snapshot repository's missing index.latest Adding equals/hashCode to MainResponse (elastic#23352) Always restore the ThreadContext for operations delayed due to a block (elastic#23349) Add support for named xcontent parsers to high level REST client (elastic#23328) Add unit tests for ParentToChildAggregator (elastic#23305) Fix after last merge with master and apply last comments [INGEST] Lazy load the geoip databases. disable BWC tests for the highlighters, need a new 5.x build to make it work Expose WordDelimiterGraphTokenFilter (elastic#23327) Test that buildCredentials returns correct clazz (elastic#23334) Add BreakIteratorBoundaryScanner support for FVH (elastic#23248) Prioritize listing index-N blobs over index.latest in reading snapshots (elastic#23333) Test: Fix hdfs test fixture setup on windows delete and index tests can share some part of the code Remove createSampleDocument method and use the sync'ed index method ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the reproduce line output when the vagrant packagingTest
fails. Before only the
gradle packagingTestwould be output, but theseed and list of versions was swallowed by groovy with an ancillary
failure (due to the
+being on the wrong line for a stringcontinuation). With the new reproduce line, it is now output next to
the task right after failure, contains the actual task (specific to the
box that fails), and contains the seed. It also no longer contains the
upgrade versions list, as the seed is used to determine which of those
to use, and the same file would be read when testing a failure on a
particular git commit. Finally, this also ties bats test setup directly
to packagingTest, instead of to the vagrant up command.