Add unit tests for ParentToChildAggregator#23305
Merged
cbuescher merged 3 commits intoelastic:masterfrom Feb 24, 2017
Merged
Conversation
Adds unit tests for the `children` aggregation. This change also add the ability to mock Mapperservice in subtests of AggregatorTestCase. Relates to elastic#22278
martijnvg
approved these changes
Feb 22, 2017
| iw.addDocument(createParentDocument("parent2")); | ||
| iw.addDocument(createChildDocument("child2", "parent2", 5)); | ||
| iw.addDocument(createChildDocument("child3", "parent2", 2)); | ||
| iw.addDocument(createChildDocument("child4", "parent2", 7)); |
Member
There was a problem hiding this comment.
maybe add some more parent/child docs here? Or add another test that tests with more docs?
Member
Author
There was a problem hiding this comment.
Sure, I will try to randomize this (number or parents, children per parent) in a simple way.
| // org.apache.lucene.search.QueryUtils$FCInvisibleMultiReader cannot be | ||
| // cast to org.apache.lucene.index.DirectoryReader | ||
| // according to @mvg this can be fixed later but requires bigger changes | ||
| IndexSearcher indexSearcher = newSearcher(indexReader, false, true); |
Member
There was a problem hiding this comment.
Sadly yes... We need to use BaseCompositeReader in the method signatures of our field data code instead of DirectoryReader.
Member
Author
There was a problem hiding this comment.
@martijnvg since you know what needs to be done, can you open an issue for this? Then I can remove the comment and link to it so we don't forget to change this to include maybeWrap at some point
Member
Author
|
@martijnvg thanks for the review, I added a commit that randomizes the test setup, unfortunately that required some more changes in the overall test structure (see follow up commit). Mind to take another quick look? |
Member
Author
|
@martijnvg thanks |
63 tasks
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 25, 2017
* master: (26 commits) CLI: Fix prompting for yes/no to handle console returning null (elastic#23320) Tests: Fix reproduce line for packagingTest (elastic#23365) Build: Remove extra copies of netty license (elastic#23361) [TEST] Removes timeout based wait_for_active_shards REST test (elastic#23360) [TEST] increase timeout slightly in wait_for_active_shards test to allow for index creation cluster state update to be processed before ensuring the wait times out Handle snapshot repository's missing index.latest Adding equals/hashCode to MainResponse (elastic#23352) Always restore the ThreadContext for operations delayed due to a block (elastic#23349) Add support for named xcontent parsers to high level REST client (elastic#23328) Add unit tests for ParentToChildAggregator (elastic#23305) Fix after last merge with master and apply last comments [INGEST] Lazy load the geoip databases. disable BWC tests for the highlighters, need a new 5.x build to make it work Expose WordDelimiterGraphTokenFilter (elastic#23327) Test that buildCredentials returns correct clazz (elastic#23334) Add BreakIteratorBoundaryScanner support for FVH (elastic#23248) Prioritize listing index-N blobs over index.latest in reading snapshots (elastic#23333) Test: Fix hdfs test fixture setup on windows delete and index tests can share some part of the code Remove createSampleDocument method and use the sync'ed index method ...
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Feb 28, 2017
Adds unit tests for the `children` aggregation. This change also add the ability to mock Mapperservice in subtests of AggregatorTestCase.
cbuescher
added a commit
that referenced
this pull request
Feb 28, 2017
Adds unit tests for the `children` aggregation. This change also add the ability to mock Mapperservice in subtests of AggregatorTestCase.
Member
Author
|
Backported to 5.x with df5d1c2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the
childrenaggregation.This change also add the ability to mock Mapperservice in subtests of
AggregatorTestCase.
Relates to #22278