Skip to content

Explicitly log cluster state update failures#15428

Merged
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:cluster-state-batch-logging
Dec 16, 2015
Merged

Explicitly log cluster state update failures#15428
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:cluster-state-batch-logging

Conversation

@jasontedor
Copy link
Copy Markdown
Member

This commit adds explicit logging at the DEBUG level for cluster state
update failures. Currently this responsibility is left to the cluster
state task listener, but we should expliclty log these with a generic
message to address cases where the listener might not.

Relates #14899, relates #15016, relates #15023

This commit adds explicit logging at the DEBUG level for cluster state
update failures. Currently this responsibility is left to the cluster
state task listener, but we should expliclty log these with a generic
message to address cases where the listener might not.

Relates #14899, relates #15016, relates #15023
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may add a message?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 02354fc.

@bleskes
Copy link
Copy Markdown
Contributor

bleskes commented Dec 16, 2015

LGTM. Left a minor suggestion about the assertions.

jasontedor added a commit that referenced this pull request Dec 16, 2015
Explicitly log cluster state update failures
@jasontedor jasontedor merged commit 89c960b into elastic:master Dec 16, 2015
@jasontedor jasontedor deleted the cluster-state-batch-logging branch December 16, 2015 15:55
@jasontedor
Copy link
Copy Markdown
Member Author

Integrated to master in 89c960b and backported to 2.x in 8632918.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants