Split cluster state update tasks into roles#14899
Split cluster state update tasks into roles#14899jasontedor merged 9 commits intoelastic:masterfrom jasontedor:cluster-state-batch
Conversation
There was a problem hiding this comment.
can we add note about the executor semantics?
There was a problem hiding this comment.
Added docs in cab59785023f6ba31a955421bd5f3a66f7799a96.
There was a problem hiding this comment.
since it seem we are going all gang-ho on java8 , rename the runnable to lambdas? :)
There was a problem hiding this comment.
Done in a7a07c77c50220dd69b60bc232cd799f33490fe3. :)
|
Oops, I got confused with the Github interface (commenting on commit instead of PR). I like the change of associating failures with their originating task using a map instead of position 👍. |
|
@ywelsch I liked your suggestion a lot so I pushed 66af98ea5b0a925e9c3dc55465c8aceb91813b6f. |
There was a problem hiding this comment.
Fixed in ff01dc904a13870bec4d11e7c9260940cbc6e6c4.
There was a problem hiding this comment.
Fixed in 7172e972e4d821048c4278117a8425f357fccc4c.
There was a problem hiding this comment.
This was lost on squash but has been integrated into master now in bbef8ac.
|
Good job. LGTM. Left some minor comments. no need for another review. |
This commit splits cluster state update tasks into roles. Those roles are: - task info - task configuration - task executor - task listener All tasks that have the same executor will be executed in batches. This removes the need for local batching as was previously in MetaDataMappingService. Additionally, this commit reintroduces batching on mapping update calls. Relates #13627
Split cluster state update tasks into roles
This commit addresses some issues that arose during the review of #14899 but were lost during squash while integrating into master. - the number of test threads is dropped to at most eight - a local variable is renamed for clarity - task priorities are randomized
This commit splits cluster state update tasks into roles. Those roles
are:
All tasks that have the same executor will be executed in batches. This
removes the need for local batching as was previously in
MetaDataMappingService.
Additionally, this commit reintroduces batching on mapping update calls.
Relates #13627