Skip to content

Fix profile non-snapshot tests#144090

Merged
carlosdelest merged 2 commits intoelastic:mainfrom
carlosdelest:tests/esql-fix-profile-tests
Mar 12, 2026
Merged

Fix profile non-snapshot tests#144090
carlosdelest merged 2 commits intoelastic:mainfrom
carlosdelest:tests/esql-fix-profile-tests

Conversation

@carlosdelest
Copy link
Copy Markdown
Member

@carlosdelest carlosdelest commented Mar 12, 2026

Some profile tests were conditioned to node_reduce phase being snapshot. As there were no capability for it when the test was build, a build snapshot condition was used.

Now we can remove the snapshot condition from the test.

Tested with ./gradlew :x-pack:plugin:esql:qa:server:single-node:javaRestTest --tests "*.RestEsqlIT.testProfile" -Dbuild.snapshot=false -Dtests.jvm.argline=-Dbuild.snapshot=false -Dlicense.key=x-pack/plugin/core/src/test/resources/public.key

Related: #144086

@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch :Search Relevance/ES|QL Search functionality in ES|QL v9.4.0 labels Mar 12, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@carlosdelest carlosdelest enabled auto-merge (squash) March 12, 2026 09:55
@carlosdelest carlosdelest merged commit 4fbe72b into elastic:main Mar 12, 2026
35 of 36 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 12, 2026
…elocations

* upstream/main: (49 commits)
  CCS logging fixes (elastic#144070)
  Improve CPS cluster exclusion handling (elastic#143488)
  Remove snapshot condition now that node_reduce phase is in non-snapshot builds (elastic#144090)
  Drop deprecation warnings when updating a mapping in the cluster state applier (elastic#143884) (elastic#144040)
  Add ensureGreenAndNoInitializingShards helper (elastic#144044)
  Removed unnecessary applies_to blocks from deprecated query (elastic#144096)
  [CPS] Use single CrossProjectModeDecider instance (elastic#144030)
  Fix ESQL TS requests with LIMIT 0 (elastic#144031)
  ESQL: Remove `create` methods in aggs (elastic#144098)
  ES|QL: Refactor ChangeLimitOperator (elastic#144017)
  Add Paginated Hit Source Tests (elastic#142592)
  Fix test failure not preferred (elastic#144019)
  Remove serialization logic from EIS authorization response (elastic#144021)
  ESQL: CSV schema inference and parsing enhancements (elastic#144050)
  ESQL: Fix incorrectly optimized fork with nullify unmapped_fields (elastic#143030)
  Fix MMR release test using subqueries (elastic#144087)
  Refactoring `UserAgentPlugin` (elastic#140712)
  Drop non-finite samples in Prometheus remote write (elastic#144055)
  [TEST] Wait for internal inference indices to be created in authorization IT (elastic#143885)
  Disable ndjson datasource QA tests in release-tests (elastic#143992)
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/ES|QL Search functionality in ES|QL Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants