Skip to content

Fix test failure not preferred#144019

Merged
kingherc merged 8 commits intoelastic:mainfrom
kingherc:test-issue/143831-alloc-pref
Mar 12, 2026
Merged

Fix test failure not preferred#144019
kingherc merged 8 commits intoelastic:mainfrom
kingherc:test-issue/143831-alloc-pref

Conversation

@kingherc
Copy link
Copy Markdown
Contributor

@kingherc kingherc commented Mar 11, 2026

See detailed reasoning on my comment on the github issue. We:

  • Reduce number of nodes and indices.
  • Wait for no relocations before ending the test.

Closes #143831

@kingherc kingherc self-assigned this Mar 11, 2026
@kingherc kingherc added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team. v9.4.0 labels Mar 11, 2026
@kingherc kingherc force-pushed the test-issue/143831-alloc-pref branch from bd7ab1e to b72a02f Compare March 11, 2026 15:21
Reduce number of nodes and indices.

Wait for no relocations before ending the test.

Closes elastic#143831
@kingherc kingherc force-pushed the test-issue/143831-alloc-pref branch from b72a02f to 8f2b20a Compare March 11, 2026 17:13
@kingherc kingherc changed the title Test failure not preferred Fix test failure not preferred Mar 11, 2026
@kingherc kingherc marked this pull request as ready for review March 11, 2026 17:17
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Contributor

@schase-es schase-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for tracking this down.

I must have run this test one thousand times to check -- it must be something that comes up when it's running on a resource-scarce machine.

In the future, we can always add a higher timeout to the awaitClusterState as well

Copy link
Copy Markdown
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2, thanks for investigating @kingherc

@kingherc kingherc merged commit 29f3919 into elastic:main Mar 12, 2026
36 checks passed
@kingherc kingherc deleted the test-issue/143831-alloc-pref branch March 12, 2026 14:00
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 12, 2026
…elocations

* upstream/main: (49 commits)
  CCS logging fixes (elastic#144070)
  Improve CPS cluster exclusion handling (elastic#143488)
  Remove snapshot condition now that node_reduce phase is in non-snapshot builds (elastic#144090)
  Drop deprecation warnings when updating a mapping in the cluster state applier (elastic#143884) (elastic#144040)
  Add ensureGreenAndNoInitializingShards helper (elastic#144044)
  Removed unnecessary applies_to blocks from deprecated query (elastic#144096)
  [CPS] Use single CrossProjectModeDecider instance (elastic#144030)
  Fix ESQL TS requests with LIMIT 0 (elastic#144031)
  ESQL: Remove `create` methods in aggs (elastic#144098)
  ES|QL: Refactor ChangeLimitOperator (elastic#144017)
  Add Paginated Hit Source Tests (elastic#142592)
  Fix test failure not preferred (elastic#144019)
  Remove serialization logic from EIS authorization response (elastic#144021)
  ESQL: CSV schema inference and parsing enhancements (elastic#144050)
  ESQL: Fix incorrectly optimized fork with nullify unmapped_fields (elastic#143030)
  Fix MMR release test using subqueries (elastic#144087)
  Refactoring `UserAgentPlugin` (elastic#140712)
  Drop non-finite samples in Prometheus remote write (elastic#144055)
  [TEST] Wait for internal inference indices to be created in authorization IT (elastic#143885)
  Disable ndjson datasource QA tests in release-tests (elastic#143992)
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Reduce number of nodes and indices.

Wait for no relocations before ending the test.

Closes elastic#143831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] NotPreferredAllocationRebalancingIT testAllocatorDoesNotMoveShardsToNotPreferredNode failing

4 participants