Revert "[ESQL] Introduce pluggable external datasource framework (#141678)#142663
Conversation
…stic#141678)" This reverts commit 6acdb30. It's causing HeapAttackIT to fail in serverless. On some machines. But not others! How exciting. For now, we'll revert and then try and get it back more slowly.
9e80fce to
b0b4b0f
Compare
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
@elasticsearchmachine test this please |
| @@ -59,12 +59,13 @@ setup: | |||
| - cosine_vector_similarity_function | |||
| - inline_stats | |||
| - promql_command_v0 | |||
| - uri_parts_command | |||
There was a problem hiding this comment.
@smalyshev why is this added here and the counter decreased?
I am adding a now command (and capability) now and I am uncertain as to what is expected
There was a problem hiding this comment.
- Counter is decreased because we're reverting a feature, so now there's one feature less
uri_parts_commandus added because in some builds, like serverless, the part withthis feature has not been picked up yet (serverless submodule is sometimes a bit behind) so it tries to run a test on the code that doesn't have this feature yet, and the count is wrong.
In general, the idea of the count is not that great and causes unending stream of failures and complications, so we want to move away from it someday soon.
There was a problem hiding this comment.
In general, the idea of the count is not that great and causes unending stream of failures and complications, so we want to move away from it someday soon.
That would be great! I am contributing to ES|QL for a short time and already experienced this as an unreasonable overhead. Multiplying that by all other contributors, this is costly. Thanks for explaining.
I am trying to follow up according to the same logic in my new PR as well...
There was a problem hiding this comment.
@eyalkoren remember to also test in the release mode (test-release label) since there are two tests there - one for snapshot and one for release.
There was a problem hiding this comment.
You mean - adding the GitHub test-release label?
There was a problem hiding this comment.
@eyalkoren yes, this label will run release mode CI tests
…astic#141678) (elastic#142663) This reverts commit 8f68c0b.
…on-sliced-reindex * upstream/main: (120 commits) [Fleet] Add OpAMP field mappings to fleet-agents (elastic#142550) Clarify `expectedSize` behaviour of `ReleasableBytesStreamOutput` (elastic#142451) Refactor KnnIndexTester to tidy up some options (elastic#142651) Fixed with elastic#142638 already (elastic#142655) Change *OverTimeTests to extend AbstractAggregationTestCase (elastic#142659) Fix byteRefBlockHashSize for release mode (elastic#142668) Mute org.elasticsearch.xpack.esql.tree.EsqlNodeSubclassTests testTransform {class org.elasticsearch.xpack.esql.plan.logical.MMR} elastic#142674 Fix PAUSED_FOR_NODE_REMOVAL shard blocking QUEUED promotion (elastic#142637) Mute org.elasticsearch.xpack.logsdb.RandomizedRollingUpgradeIT testIndexingStandardSource elastic#142670 Revert "[ESQL] Introduce pluggable external datasource framework (elastic#141678) (elastic#142663) Mute org.elasticsearch.xpack.esql.spatial.SpatialPushDownGeoShapeIT testQuantizedXY elastic#141234 PromQL: infer start/end from query DSL filters (elastic#142580) Add GPU vector indexing monitoring to _xpack/usage (elastic#141932) Fix testTrackerClearShutdown: use non-zero startTimeMillis for DONE status (elastic#142646) Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#142426 ESQL_ Move time_zone to GA (elastic#142287) Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#142426 DOCS: Convert Painless diagrams to mermaid (elastic#141851) ES|QL: fix validation in generative tests (elastic#142638) Unmute tests that do not reproduce failures (elastic#141712) ...
This reverts commit 6acdb30. It's causing HeapAttackIT to fail in serverless. On some machines. But not others! How exciting.
For now, we'll revert and then try and get it back more slowly.
For context: this fails for me reliably on serverless main:
Fails with different seeds too. Does not fail with this revert.