Skip to content

Change *OverTimeTests to extend AbstractAggregationTestCase#142659

Merged
kkrik-es merged 2 commits intoelastic:mainfrom
kkrik-es:tsdb/time-series-aggs-test-case
Feb 19, 2026
Merged

Change *OverTimeTests to extend AbstractAggregationTestCase#142659
kkrik-es merged 2 commits intoelastic:mainfrom
kkrik-es:tsdb/time-series-aggs-test-case

Conversation

@kkrik-es
Copy link
Copy Markdown
Member

This unlocks proper unittest coverage. Tests for data types using surrogates (amd, histograms), indicated that these classes should also implement SurrogateExpression.

Fixes #142558

@kkrik-es kkrik-es self-assigned this Feb 18, 2026
@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests Team:StorageEngine :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL labels Feb 18, 2026
@kkrik-es kkrik-es requested a review from dnhatn February 18, 2026 19:36
@kkrik-es kkrik-es marked this pull request as ready for review February 18, 2026 19:36
@kkrik-es kkrik-es changed the title Change *OverTimeTests to inherit from AbstractAggregationTestCase Change *OverTimeTests to extend AbstractAggregationTestCase Feb 18, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Kostas!

@kkrik-es kkrik-es merged commit 3c0342a into elastic:main Feb 19, 2026
35 checks passed
@kkrik-es kkrik-es deleted the tsdb/time-series-aggs-test-case branch February 19, 2026 13:22
szybia added a commit to szybia/elasticsearch that referenced this pull request Feb 19, 2026
…on-sliced-reindex

* upstream/main: (120 commits)
  [Fleet] Add OpAMP field mappings to fleet-agents (elastic#142550)
  Clarify `expectedSize` behaviour of `ReleasableBytesStreamOutput` (elastic#142451)
  Refactor KnnIndexTester to tidy up some options (elastic#142651)
  Fixed with elastic#142638 already (elastic#142655)
  Change *OverTimeTests to extend AbstractAggregationTestCase (elastic#142659)
  Fix byteRefBlockHashSize for release mode (elastic#142668)
  Mute org.elasticsearch.xpack.esql.tree.EsqlNodeSubclassTests testTransform {class org.elasticsearch.xpack.esql.plan.logical.MMR} elastic#142674
  Fix PAUSED_FOR_NODE_REMOVAL shard blocking QUEUED promotion (elastic#142637)
  Mute org.elasticsearch.xpack.logsdb.RandomizedRollingUpgradeIT testIndexingStandardSource elastic#142670
  Revert "[ESQL] Introduce pluggable external datasource framework (elastic#141678) (elastic#142663)
  Mute org.elasticsearch.xpack.esql.spatial.SpatialPushDownGeoShapeIT testQuantizedXY elastic#141234
  PromQL: infer start/end from query DSL filters (elastic#142580)
  Add GPU vector indexing monitoring to _xpack/usage (elastic#141932)
  Fix testTrackerClearShutdown: use non-zero startTimeMillis for DONE status (elastic#142646)
  Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#142426
  ESQL_ Move time_zone to GA (elastic#142287)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#142426
  DOCS: Convert Painless diagrams to mermaid (elastic#141851)
  ES|QL: fix validation in generative tests (elastic#142638)
  Unmute tests that do not reproduce failures (elastic#141712)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: Agg over time function tests not inheriting from AbstractAggregationTestCase

3 participants