Store fallback match only text fields in binary doc values#140189
Merged
Kubik42 merged 6 commits intoelastic:mainfrom Jan 12, 2026
Merged
Store fallback match only text fields in binary doc values#140189Kubik42 merged 6 commits intoelastic:mainfrom
Kubik42 merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
b7b1f1c to
c7a328b
Compare
Contributor
Author
|
Error in serverless seems unrelated to my changes: #140243 (same error) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
5a7dac4 to
c9dbc6c
Compare
Contributor
ce46054 to
21ac2db
Compare
Contributor
Author
f8ce5ef to
d91843a
Compare
Kubik42
commented
Jan 8, 2026
| if (isSyntheticSourceEnabled()) { | ||
| if (storeFallbackFieldsInBinaryDocValues(indexCreatedVersion, indexMode)) { | ||
| // For newer indexes, fallback data is stored in binary doc values | ||
| return (cache, breaker) -> new BytesBinaryIndexFieldData( |
Contributor
Author
There was a problem hiding this comment.
The legacy (below) implementation uses sorted stored fields. We don't need to sort binary doc values explicitly because of #140244
martijnvg
reviewed
Jan 9, 2026
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class MatchOnlyTextRollingUpgradeIT extends AbstractStringTypeLogsdbRollingUpgradeTestCase { |
Member
There was a problem hiding this comment.
Let's do this in a seperate PR? This should also replace the existing MatchOnlyTextRollingUpgradeIT?
Contributor
Author
There was a problem hiding this comment.
imo, this should be bundled in this PR since we're making changes to match only text. Wouldn't want to push something into main that has a bug that these tests would've caught.
And yes, this will replace the legacy MatchOnlyTextRollingUpgradeIT. I will delete it in a follow up PR.
...per-extras/src/main/java/org/elasticsearch/index/mapper/extras/MatchOnlyTextFieldMapper.java
Outdated
Show resolved
Hide resolved
...per-extras/src/main/java/org/elasticsearch/index/mapper/extras/MatchOnlyTextFieldMapper.java
Outdated
Show resolved
Hide resolved
# Conflicts: # libs/swisshash/src/main/java/module-info.java # x-pack/plugin/logsdb/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/xpack/logsdb/KeywordRollingUpgradeIT.java
# Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # server/src/main/java/org/elasticsearch/index/mapper/MultiValuedBinaryDocValuesField.java # server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java
d78b5a3 to
bd8566f
Compare
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jan 12, 2026
…i-project-tests * upstream/main: (23 commits) Fix `testAckListenerReceivesNacksIfPublicationTimesOut` (elastic#140514) Reduce priority of clear-cache tasks (elastic#139685) Add docs and tests about `StreamOutput` to memory (elastic#140365) ES|QL - dense_vector support for COUNT, PRESENT, ABSENT aggregator functions (elastic#139914) Add release notes for v9.2.4 release (elastic#140487) Add release notes for v9.1.10 release (elastic#140488) Add conncectors release notes for 9.1.10, 9.2.4 (elastic#140499) Add parameter support in PromQL query durations (elastic#139873) Improve testing of STS credentials reloading (elastic#140114) Fix zstd native binary publishing script to support newer versions (elastic#140485) Add FlattenedFieldBinaryVsSortedSetDocValuesSyntheticSourceIT (elastic#140489) Store fallback match only text fields in binary doc values (elastic#140189) [DiskBBQ] Use the new merge executor for intra-merge parallelism (elastic#139942) ESQL: introduce support for mapping-unavailable fields (elastic#140463) Add ESNextOSQVectorsScorerTests (elastic#140436) Disable high cardinality tests on release builds (elastic#140503) ESQL: TRange timezone support (elastic#139911) Directly compressing `StreamOutput` (elastic#140502) ES|QL - fix dense vector enrich bug (elastic#139774) Use CrossProjectModeDecider in RemoteClusterService (elastic#140481) ...
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
…40189) * testing * Migrate TextRollingUpgradeIT to run in serverless # Conflicts: # libs/swisshash/src/main/java/module-info.java # x-pack/plugin/logsdb/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/xpack/logsdb/KeywordRollingUpgradeIT.java * Store fallback text fields in binary doc values # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java # server/src/main/java/org/elasticsearch/index/mapper/MultiValuedBinaryDocValuesField.java # server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java * Store fallback match only text fields in binary doc values * Addressed feedback, cleaned up some tests * Update docs/changelog/140189.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/elastic/logs-program/issues/22