Skip to content

allocation: unmute failed decider test that was fixed elsewhere#140243

Merged
schase-es merged 1 commit intoelastic:mainfrom
schase-es:test-failures/138924-unmute-write-load-constraint-decider
Jan 8, 2026
Merged

allocation: unmute failed decider test that was fixed elsewhere#140243
schase-es merged 1 commit intoelastic:mainfrom
schase-es:test-failures/138924-unmute-write-load-constraint-decider

Conversation

@schase-es
Copy link
Copy Markdown
Contributor

@schase-es schase-es commented Jan 6, 2026

The write load constraint decider test, as originally written, had a threshold error when creating a node that was not hotspotting: roughly one in three thousand nodes would accidentally receive a metric that would test as hot. This was already fixed in issue #139161.

Fixes: #138924

The write load constraint decider test, as originally written, had a threshold
error when creating a node that was not hotspotting: roughly one in three
thousand nodes would accidentally receive a metric that would test as hot. This
was already fixed because of issue 139161.

Fixes: elastic#138924
@schase-es schase-es added >non-issue >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) auto-backport Automatically create backport pull requests when merged Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. v9.3.1 v9.4.0 labels Jan 6, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@schase-es
Copy link
Copy Markdown
Contributor Author

Test failure is: #138924
Related test failure is: #139161
Original PR is: #139163

Copy link
Copy Markdown
Contributor

@joshua-adams-1 joshua-adams-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to see if this is working now 👍

Copy link
Copy Markdown
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks.

Nit: I'd reference #139163 in your commit message, which points at the fix, rather than the other bug ticket (#139161).

@schase-es schase-es merged commit 2cd01a7 into elastic:main Jan 8, 2026
35 checks passed
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
9.3

schase-es added a commit to schase-es/elasticsearch that referenced this pull request Jan 8, 2026
…tic#140243)

The write load constraint decider test, as originally written, had a threshold
error when creating a node that was not hotspotting: roughly one in three
thousand nodes would accidentally receive a metric that would test as hot. This
was already fixed in elastic#139163.

Fixes: elastic#138924
jimczi pushed a commit to jimczi/elasticsearch that referenced this pull request Jan 12, 2026
…tic#140243)

The write load constraint decider test, as originally written, had a threshold
error when creating a node that was not hotspotting: roughly one in three
thousand nodes would accidentally receive a metric that would test as hot. This
was already fixed in elastic#139163.

Fixes: elastic#138924
elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2026
…#140243) (#140407)

* allocation: unmute failed decider test that was fixed elsewhere (#140243)

The write load constraint decider test, as originally written, had a threshold
error when creating a node that was not hotspotting: roughly one in three
thousand nodes would accidentally receive a metric that would test as hot. This
was already fixed in #139163.

Fixes: #138924

* Fixing up merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. >test Issues or PRs that are addressing/adding tests v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] WriteLoadConstraintMonitorTests testRerouteIsNotCalledWhenNoNodesAreHotSpotting failing

4 participants