Skip to content

Add back support for deserializing old authentication in test#139811

Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom
jfreden:fix_token_tests
Dec 19, 2025
Merged

Add back support for deserializing old authentication in test#139811
elasticsearchmachine merged 2 commits intoelastic:mainfrom
jfreden:fix_token_tests

Conversation

@jfreden
Copy link
Copy Markdown
Contributor

@jfreden jfreden commented Dec 19, 2025

This test sometimes (randomly) generates a stored authentication object serialized using 7.X. Since it's stored auth that needs to be supported and that's also why this test fails after removing special handling for it.

Resolves: #139026, #139031

@jfreden jfreden requested a review from a team December 19, 2025 12:42
@jfreden jfreden added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label labels Dec 19, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Dec 19, 2025
@jfreden jfreden changed the title Add back support for deserializing old refresh token in test Add back support for deserializing old authentication in test Dec 19, 2025
@jfreden jfreden added auto-backport Automatically create backport pull requests when merged branch:9.3 labels Dec 19, 2025
Copy link
Copy Markdown
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jfreden jfreden added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 19, 2025
@jfreden jfreden linked an issue Dec 19, 2025 that may be closed by this pull request
@elasticsearchmachine elasticsearchmachine merged commit a103e3d into elastic:main Dec 19, 2025
41 checks passed
@jfreden jfreden deleted the fix_token_tests branch December 19, 2025 14:49
jfreden added a commit to jfreden/elasticsearch that referenced this pull request Dec 19, 2025
…#139811)

This test sometimes (randomly) generates a stored authentication object
serialized using 7.X. Since it's stored auth that needs to be supported
and that's also why this test fails after [removing special handling for
it](https://github.com/elastic/elasticsearch/pull/139018/files#diff-d4a20b10b16547e676296d3cb974eaf83b608be71ad0c278fb397891294a1451L560-L573).

Resolves: elastic#139026,
elastic#139031
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
9.3

szybia added a commit to szybia/elasticsearch that referenced this pull request Dec 19, 2025
* upstream/main:
  Update text_similarity_rank_retriever to support inference ID as an argument when reranking on chunks (elastic#137397)
  Mute org.elasticsearch.test.rest.yaml.CssSearchYamlTestSuiteIT test {p0=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification multiple indexes} elastic#139826
  Mute org.elasticsearch.index.mapper.SkipperSettingsTests testTSDBSkipperSettingDefaults elastic#139824
  Unmute test fix elastic#129517 (elastic#139782)
  Add back support for deserializing old refresh token in test (elastic#139811)
  Add documentation for exponential_histogram field type (elastic#139684)
  make ES|QL sample CSV test looser (elastic#139814)
  Add `frozen_after` field to data stream lifecycle (elastic#139042)
  Quieten many `ERROR` logs to `WARN` (elastic#139799)
elasticsearchmachine pushed a commit that referenced this pull request Dec 19, 2025
#139823)

This test sometimes (randomly) generates a stored authentication object
serialized using 7.X. Since it's stored auth that needs to be supported
and that's also why this test fails after [removing special handling for
it](https://github.com/elastic/elasticsearch/pull/139018/files#diff-d4a20b10b16547e676296d3cb974eaf83b608be71ad0c278fb397891294a1451L560-L573).

Resolves: #139026,
#139031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] TokenServiceTests testSupersedingTokenEncryption failing [CI] TokenServiceTests testInvalidateRefreshTokenThatIsAlreadyInvalidated failing

3 participants