Skip to content

Quieten many ERROR logs to WARN#139799

Merged
DaveCTurner merged 3 commits intoelastic:mainfrom
DaveCTurner:2025/12/19/quiten-error-logs
Dec 19, 2025
Merged

Quieten many ERROR logs to WARN#139799
DaveCTurner merged 3 commits intoelastic:mainfrom
DaveCTurner:2025/12/19/quiten-error-logs

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner commented Dec 19, 2025

Today we're egregiously over-using the ERROR log level to report
situations that do occur sometimes but which can safely be ignored. At
least, we are in practice already ignoring these things despite the
overly-dramatic logging. In order to move to a model where we can rely
on elevated ERROR logging as an indicator of a truly release-stopping
bug, this commit reduces a number of the worst offenders down to level
WARN.

Today we're egregiously over-using the `ERROR` log level to report
situations that do occur sometimes but which can safely be ignored. At
least, we are in practice already ignoring these things despite the
overly-dramatic logging. In order to move to a model where we can rely
on elevated `ERROR` logging as an indicator of a truly release-stopping
bugs, this commit reduces a number of the worst offenders down to level
`WARN`.
@DaveCTurner DaveCTurner requested review from jimczi and mosche December 19, 2025 10:48
@DaveCTurner DaveCTurner added >non-issue :Core/Infra/Logging Log management and logging utilities v9.4.0 labels Dec 19, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 19, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Dec 19, 2025

I know it's not really :Core/Infra/Logging in the sense of logging utilities & infrastructure but it cuts across a bunch of areas and I had to pick something...

@DaveCTurner DaveCTurner enabled auto-merge (squash) December 19, 2025 10:57
Copy link
Copy Markdown
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 100d1b1 into elastic:main Dec 19, 2025
35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Dec 19, 2025
* upstream/main:
  Update text_similarity_rank_retriever to support inference ID as an argument when reranking on chunks (elastic#137397)
  Mute org.elasticsearch.test.rest.yaml.CssSearchYamlTestSuiteIT test {p0=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification multiple indexes} elastic#139826
  Mute org.elasticsearch.index.mapper.SkipperSettingsTests testTSDBSkipperSettingDefaults elastic#139824
  Unmute test fix elastic#129517 (elastic#139782)
  Add back support for deserializing old refresh token in test (elastic#139811)
  Add documentation for exponential_histogram field type (elastic#139684)
  make ES|QL sample CSV test looser (elastic#139814)
  Add `frozen_after` field to data stream lifecycle (elastic#139042)
  Quieten many `ERROR` logs to `WARN` (elastic#139799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Logging Log management and logging utilities >non-issue Team:Core/Infra Meta label for core/infra team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants