Guard inlinestats tests in release builds#134915
Merged
dnhatn merged 1 commit intoelastic:mainfrom Sep 17, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
astefan
reviewed
Sep 17, 2025
| } | ||
|
|
||
| protected static String randomStats() { | ||
| return INLINESTATS_SUPPORTS_REMOTE.isEnabled() ? randomFrom("STATS", "INLINESTATS") : "STATS"; |
Contributor
There was a problem hiding this comment.
I think this should somehow include INLINESTATS_V11 as well.
Member
Author
There was a problem hiding this comment.
This is an IntegTest, which run only with the current version.
smalyshev
approved these changes
Sep 17, 2025
Contributor
|
Oh, didn't realize it's snapshot-only. Thanks! |
Member
Author
|
@astefan @smalyshev Thanks! |
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Some InlineStats tests failed in release builds (see elastic#134768). We need to guard these tests with capability checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some InlineStats tests failed in release builds (see #134768). We need to guard these tests with capability checks.