Enable TS command in non-snapshot builds#134768
Conversation
d335d29 to
8494f86
Compare
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
63ce6bc to
022c862
Compare
| /** | ||
| * The metrics command | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
What about AGGREGATE_METRIC_DOUBLE_FEATURE_FLAG, do the same? @limotova fyi.
limotova
left a comment
There was a problem hiding this comment.
LGTM! Just some questions
|
|
||
| absent_over_time_of_aggregate_metric_double | ||
| required_capability: metrics_command | ||
| required_capability: absent_over_time |
There was a problem hiding this comment.
Why are we removing the absent_over_time capability here/replacing it with agg_metric but still keeping it everywhere else? (Same with the test absent_over_time_older_than_10d and similar present_over_time tests)
There was a problem hiding this comment.
Because aggregate_metric_double still requires snapshot builds, while TS is available in both snapshot and release builds, we need to skip these tests in release builds (since aggregate_metric_double is not yet supported).
There was a problem hiding this comment.
i think i didn't phrase my question well, i was more wondering why the absent_over_time capability was being only removed here and not anywhere else?
There was a problem hiding this comment.
We should remove it everywhere, but this PR is getting too large. I will address this in a follow-up.
| irate_of_aggregate_metric | ||
| required_capability: metrics_command | ||
| required_capability: ts_command_v0 | ||
| required_capability: aggregate_metric_double |
There was a problem hiding this comment.
I don't think this test uses aggregate_metric_double (I believe network.total_bytes_in is a counter_long)
| rate_of_aggregate_metric | ||
| required_capability: metrics_command | ||
| required_capability: ts_command_v0 | ||
| required_capability: aggregate_metric_double |
There was a problem hiding this comment.
Same for here, I don't think this uses aggregate_metric_double
| max_over_time | ||
| required_capability: metrics_command | ||
| required_capability: ts_command_v0 | ||
| required_capability: max_over_time |
There was a problem hiding this comment.
Why are we keeping the max/min/etc_over_time capabilities here?
There was a problem hiding this comment.
Yeah, we should remove all capability except for ts_command_v0. I will do this in a follow-up.
Some InlineStats tests failed in release builds (see #134768). We need to guard these tests with capability checks.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
Some InlineStats tests failed in release builds (see elastic#134768). We need to guard these tests with capability checks.
This change enables the TS command in non-snapshot builds. We are also starting to run BWC tests for the TS command, including mixed-cluster and cross-cluster tests. Note that some validations for the TS command still need improvement, but it is fine to address these after this PR.
This change enables the TS command in non-snapshot builds. We are also starting to run BWC tests for the TS command, including mixed-cluster and cross-cluster tests. Note that some validations for the TS command still need improvement, but it is fine to address these after this PR.