[8.19] Fixes flaky ST_CENTROID_AGG tests (#114892)#128037
Merged
elasticsearchmachine merged 2 commits intoelastic:8.19from May 12, 2025
Merged
[8.19] Fixes flaky ST_CENTROID_AGG tests (#114892)#128037elasticsearchmachine merged 2 commits intoelastic:8.19from
elasticsearchmachine merged 2 commits intoelastic:8.19from
Conversation
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
This was referenced May 12, 2025
Collaborator
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 12, 2025
…8037) * Fixes flaky ST_CENTROID_AGG tests (elastic#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 12, 2025
…8037) * Fixes flaky ST_CENTROID_AGG tests (elastic#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2025
* Fixes flaky ST_CENTROID_AGG tests (#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2025
* Fixes flaky ST_CENTROID_AGG tests (#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #114892
Fixes #127864