Fixes flaky ST_CENTROID_AGG tests#114892
Merged
craigtaverner merged 1 commit intoelastic:mainfrom Oct 16, 2024
Merged
Conversation
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
iverase
approved these changes
Oct 16, 2024
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 16, 2024
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 12, 2025
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2025
* Fixes flaky ST_CENTROID_AGG tests (#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
This was referenced May 12, 2025
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 12, 2025
…8037) * Fixes flaky ST_CENTROID_AGG tests (elastic#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 12, 2025
…8037) * Fixes flaky ST_CENTROID_AGG tests (elastic#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2025
* Fixes flaky ST_CENTROID_AGG tests (#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2025
* Fixes flaky ST_CENTROID_AGG tests (#114892) Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about. * Unmute after cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with Kahan summation, we were occasionally getting floating point differences at the 14th decimal point, well beyond anything a GIS use case would care about.
Fixes #112461
Fixes #112463