Don't return or accept node_version in the Desired Nodes API #119049
Merged
arteam merged 19 commits intoelastic:mainfrom Feb 5, 2025
Merged
Don't return or accept node_version in the Desired Nodes API #119049arteam merged 19 commits intoelastic:mainfrom
node_version in the Desired Nodes API #119049arteam merged 19 commits intoelastic:mainfrom
Conversation
…ic#114580) > It was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0 Note: This PR is still pending on the 9.0 transport version
…nto 2-remove-desired-nodes-status
a1b5f5e to
9c02c10
Compare
9c02c10 to
6c0bc0c
Compare
DaveCTurner
approved these changes
Feb 5, 2025
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM. It is vital that this is backported to 9.0 tho.
server/src/main/java/org/elasticsearch/cluster/metadata/DesiredNode.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 5, 2025
…lastic#119049) Backports elastic#119049 to 9.0 > Re-submission of elastic#114580 > node_version was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submission of #114580
Resolve ES-9443