Don't return or accept node_version in the Desired Nodes API#114580
Merged
arteam merged 15 commits intoelastic:mainfrom Oct 24, 2024
Merged
Don't return or accept node_version in the Desired Nodes API#114580arteam merged 15 commits intoelastic:mainfrom
node_version in the Desired Nodes API#114580arteam merged 15 commits intoelastic:mainfrom
Conversation
It was deprecated in elastic#104209 (8.13) and shouldn't be set in 9.0
This reverts commit 0400428.
node_version field from DesiredNode API outputnode_version in the DesiredNode API
node_version in the DesiredNode APInode_version in the Desired Nodes API
8c662fa to
4ef63e4
Compare
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
server/src/main/java/org/elasticsearch/cluster/metadata/DesiredNode.java
Outdated
Show resolved
Hide resolved
mark-vieira
approved these changes
Oct 23, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…ic#114580) It was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0 The Desired Nodes API is an internal API, and users shouldn't depend on its backward compatibility.
Member
Hi @arteam, this isn't true, we need to preserve the v8 behaviour (i.e. the deprecation warnings) if the user is using the v8 API. Also really this one needs transport version changes so we can't really address it until after v8.last FF. It's going to be tricky to address these issues correctly on top of this change so I'd rather that you reverted it and then we can follow up later on. |
Contributor
Author
|
Waiting until we have TransportVersions_V9 and I will keep the |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…ic#114580) It was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0 The Desired Nodes API is an internal API, and users shouldn't depend on its backward compatibility.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
elastic#114580)" (elastic#115829) This reverts commit c64226c.
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Dec 19, 2024
…ic#114580) > It was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0 Note: This PR is still pending on the 9.0 transport version
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 5, 2025
…lastic#119049) Backports elastic#119049 to 9.0 > Re-submission of elastic#114580 > node_version was deprecated in elastic#104209 (8.13) and shouldn't be set or returned in 9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was deprecated in #104209 (8.13) and shouldn't be set or returned in 9.0
The Desired Nodes API is an internal API, and users shouldn't depend on its backward compatibility.