Skip to content

Remove legacy join validation transport protocol#114571

Merged
arteam merged 7 commits intoelastic:mainfrom
arteam:remove-legacy-join-validation
Oct 24, 2024
Merged

Remove legacy join validation transport protocol#114571
arteam merged 7 commits intoelastic:mainfrom
arteam:remove-legacy-join-validation

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented Oct 11, 2024

We introduced a new join validation protocol in #85380 (8.3), the legacy protocol can be removed in 9.0

We introduced a new join validation protocol in elastic#102372 (8.3), the
legacy protocol can be removed in 9.0
@arteam arteam added WIP :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Oct 11, 2024
@arteam arteam marked this pull request as ready for review October 16, 2024 08:06
@arteam arteam requested a review from DaveCTurner October 16, 2024 08:07
@arteam arteam removed the WIP label Oct 17, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Oct 17, 2024
Copy link
Copy Markdown
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we don't need to send a specific error when the remote is running an ancient version? I assume that's handled somewhere more generally?

@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Oct 23, 2024

@nicktindall Yes, I believe it's checked in NodeJoinExecutor.ensureVersionBarrier before we perform the cluster state validation.

@arteam arteam merged commit f5d3c7c into elastic:main Oct 24, 2024
@arteam arteam deleted the remove-legacy-join-validation branch October 24, 2024 15:09
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
We introduced a new join validation protocol in elastic#85380 (8.3), the legacy protocol can be removed in 9.0

Remove assertion that we run a version after 8.3.0
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
We introduced a new join validation protocol in elastic#85380 (8.3), the legacy protocol can be removed in 9.0

Remove assertion that we run a version after 8.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue >refactoring Team:Distributed Meta label for distributed team. v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants