Migrate JoinValidationService to TransportVersion#102372
Merged
DaveCTurner merged 1 commit intoelastic:mainfrom Nov 20, 2023
Merged
Migrate JoinValidationService to TransportVersion#102372DaveCTurner merged 1 commit intoelastic:mainfrom
DaveCTurner merged 1 commit intoelastic:mainfrom
Conversation
We introduced a new join validation protocol in version 8.3, effectively a different transport protocol. However today we are still checking the node's release version when deciding which validation protocol to use. This commit migrates to using the `TransportVersion` of the relevant connection.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Nov 20, 2023
Contributor
ldematte
left a comment
There was a problem hiding this comment.
Looks good but I have a minor comment/question
| // This node isn't in the cluster yet so ClusterState#getMinTransportVersion() doesn't apply, we must obtain a specific connection | ||
| // so we can check its transport version to decide how to proceed. | ||
|
|
||
| final Transport.Connection connection; |
Contributor
There was a problem hiding this comment.
Nit: who is going to close the connection?
The behaviour should be the same as before, as the connection was opened but not closed in the original location in doRun as well, so I suppose it's not a problem.
Member
Author
There was a problem hiding this comment.
We are not opening the connection here, just getting a connection that someone else is responsible for opening. Its lifecycle is managed here:
Contributor
There was a problem hiding this comment.
Thanks for the code pointer!
Yeah, I should have said "obtained", not "opened" :)
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 11, 2024
We introduced a new join validation protocol in elastic#102372 (8.3), the legacy protocol can be removed in 9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced a new join validation protocol in version 8.3, effectively
a different transport protocol. However today we are still checking the
node's release version when deciding which validation protocol to use.
This commit migrates to using the
TransportVersionof the relevantconnection.