Remove deprecations and 7.x related code from analysis common#113009
Merged
javanna merged 3 commits intoelastic:mainfrom Sep 18, 2024
Merged
Remove deprecations and 7.x related code from analysis common#113009javanna merged 3 commits intoelastic:mainfrom
javanna merged 3 commits intoelastic:mainfrom
Conversation
edgeNGram and NGram tokenizers and token filters were deprecated. They have not been supported in indices created from 8.0, hence their support can entirely be removed from main. The version related logic around the min grams can also be removed as it refers to 7.x which we no longer need to support. Relates to elastic#50376, elastic#50862, elastic#43568
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @javanna, I've created a changelog YAML for you. Note that since this PR is labelled |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 18, 2024
…c#113009) edgeNGram and NGram tokenizers and token filters were deprecated. They have not been supported in indices created from 8.0, hence their support can entirely be removed from main. The version related logic around the min grams can also be removed as it refers to 7.x which we no longer need to support. Relates to elastic#50376, elastic#50862, elastic#43568
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 18, 2024
…elastic#113009)" This reverts commit ef37511.
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 18, 2024
This reverts elastic#113009 and re-adds previous v7 tests since we now support v7 indices as read-only on v9.
cbuescher
added a commit
that referenced
this pull request
Dec 18, 2024
This reverts #113009 and re-introduces v7 compatibility logic and previous v7 tests since we now support v7 indices as read-only on v9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edgeNGram and NGram tokenizers and token filters were deprecated. They have not been supported in indices created from 8.0, hence their support can entirely be removed from main.
The version related logic around the min grams can also be removed as it refers to 7.x which we no longer need to support.
Relates to #50376, #50862, #43568