Revert 7.x related code from analysis common#118972
Merged
cbuescher merged 4 commits intoelastic:mainfrom Dec 18, 2024
Merged
Conversation
…elastic#113009)" This reverts commit ef37511.
This reverts elastic#113009 and re-adds previous v7 tests since we now support v7 indices as read-only on v9.
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Dec 18, 2024
| // This is already broken with normalization, so backwards compat isn't necessary? | ||
| tokenizers.add(PreConfiguredTokenizer.singleton("lowercase", XLowerCaseTokenizer::new)); | ||
|
|
||
| // Temporary shim for aliases. TODO deprecate after they are moved |
Contributor
There was a problem hiding this comment.
is the TODO still valid here?
Member
Author
There was a problem hiding this comment.
I did some spelunking and believe this was introduced in some darker ages when PRs were still 5 digits long: https://github.com/elastic/elasticsearch/pull/24751/files#diff-dfbfed296c89aa1897a8f3e2ea119717f0c2d2577f4ee9757e5e477d88019f16R309
It somehow survived many code moves. Kudos to that, little friend. I'm pretty sure its time to go now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #113009 and re-introduces v7 compatibility logic and previous v7 tests
since we now support v7 indices as read-only on v9.