Abstract codec lookup by name, to make CodecService extensible#111007
Merged
ldematte merged 6 commits intoelastic:mainfrom Jul 24, 2024
Merged
Abstract codec lookup by name, to make CodecService extensible#111007ldematte merged 6 commits intoelastic:mainfrom
ldematte merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
commented
Jul 18, 2024
|
|
||
| import org.apache.lucene.codecs.Codec; | ||
|
|
||
| public class FilterCodecService implements CodecSupplier { |
Contributor
Author
There was a problem hiding this comment.
This is not strictly needed here, it will be used by extending code, but thought it would be nice to have (mimicking the various Filter* implementations in Lucene). But I'm OK to remove it if you think it does not belong here.
Contributor
There was a problem hiding this comment.
Given this could be just a lambda, I'd suggest to remove it from ES. But no strong opinion on this.
ldematte
commented
Jul 18, 2024
| * @return the {@link CodecSupplier} | ||
| */ | ||
| public CodecService getCodecService() { | ||
| public CodecSupplier getCodecService() { |
Contributor
Author
There was a problem hiding this comment.
This could/should be renamed, but wanted to check with reviewers names were good (e.g. CodecSupplier) before doing it. Wdyt?
Contributor
There was a problem hiding this comment.
yes, I think it should be renamed unless it touches a million places. Is it going to break the serverless build if renaming?
Contributor
Author
There was a problem hiding this comment.
I don't think so, but I'll try (add the label)
mosche
reviewed
Jul 18, 2024
server/src/main/java/org/elasticsearch/index/codec/CodecSupplier.java
Outdated
Show resolved
Hide resolved
mosche
approved these changes
Jul 18, 2024
Contributor
mosche
left a comment
There was a problem hiding this comment.
A minor suggestion on the name, but I prefer this approach 👍
lgtm
mosche
reviewed
Jul 24, 2024
server/src/main/java/org/elasticsearch/index/codec/CodecProvided.java
Outdated
Show resolved
Hide resolved
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 25, 2024
* main: (39 commits) Update README.asciidoc (elastic#111244) ESQL: INLINESTATS (elastic#109583) ESQL: Document a little of `DataType` (elastic#111250) Relax assertions in segment level field stats (elastic#111243) LogsDB data generator - support nested object field (elastic#111206) Validate `Authorization` header in Azure test fixture (elastic#111242) Fixing HistoryStoreTests.testPut() and testStoreWithHideSecrets() (elastic#111246) [ESQL] Remove Named Expcted Types map from testing infrastructure (elastic#111213) Change visibility of createWriter to allow tests from a different package to override it (elastic#111234) [ES|QL] Remove EsqlDataTypes (elastic#111089) Mute org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests testReadNonexistentBlobThrowsNoSuchFileException elastic#111233 Abstract codec lookup by name, to make CodecService extensible (elastic#111007) Add HTTPS support to `AzureHttpFixture` (elastic#111228) Unmuting tests related to free_context action being processed in ESSingleNodeTestCase (elastic#111224) Upgrade Azure SDK (elastic#111225) Collapse transport versions for 8.14.0 (elastic#111199) Make sure contender uses logs templates (elastic#111183) unmute HistogramPercentileAggregationTests.testBoxplotHistogram (elastic#111223) Refactor Quality Assurance test infrastructure (elastic#111195) Mute org.elasticsearch.xpack.restart.FullClusterRestartIT testDisableFieldNameField {cluster=UPGRADED} elastic#111222 ... # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the minimal change we can make to make it possible for use to provide a custom Codec/DocValuesFormat when using it via
EngineConfigin aEnginePlugin'sEngineFactory(basically this is just a "extract interface" here).An alternative (implemented here - main...ldematte/internal-engine-change) is to make
InternalEngine#getIndexWriterConfigextensible (protected); I think this one is cleaner and more in line with existing code (e.g. to use a custom Lucene MergePolicy we also make it changeable viaEngineFactory), but I'm fine either way.