Tidy master-node timeouts in put/delete shutdown APIs#108850
Merged
elasticsearchmachine merged 6 commits intoelastic:mainfrom May 23, 2024
Merged
Tidy master-node timeouts in put/delete shutdown APIs#108850elasticsearchmachine merged 6 commits intoelastic:mainfrom
elasticsearchmachine merged 6 commits intoelastic:mainfrom
Conversation
Cleaning up the version logic added in elastic#107862 a little, and also removing some usages of `TRAPPY_IMPLICIT_DEFAULT_MASTER_NODE_TIMEOUT` as per elastic#107984.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ywangd
approved these changes
May 23, 2024
| if (out.getTransportVersion().isPatchFrom(TransportVersions.V_8_13_4) | ||
| || out.getTransportVersion().isPatchFrom(TransportVersions.SHUTDOWN_REQUEST_TIMEOUTS_FIX_8_14) | ||
| || out.getTransportVersion().onOrAfter(TransportVersions.SHUTDOWN_REQUEST_TIMEOUTS_FIX)) { | ||
| if (serializedWithParentTaskAndTimeouts(out.getTransportVersion())) { |
Member
There was a problem hiding this comment.
Nit: the name serializedWithParentTaskAndTimeouts reads a bit strange when it is used in a method where serialization is yet to happen. Maybe supportsSerializeWithParentTaskAndTimeouts?
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up the version logic added in #107862 a little, and also
removing some usages of
TRAPPY_IMPLICIT_DEFAULT_MASTER_NODE_TIMEOUTasper #107984.