Skip to content

Fix serialization of put/delete shutdown requests#107862

Merged
thecoop merged 9 commits intoelastic:mainfrom
DaveCTurner:2024/04/24/put-shutdown-request-bug
May 3, 2024
Merged

Fix serialization of put/delete shutdown requests#107862
thecoop merged 9 commits intoelastic:mainfrom
DaveCTurner:2024/04/24/put-shutdown-request-bug

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

Closes #107857

@DaveCTurner DaveCTurner added >bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v8.15.0 labels Apr 24, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 24, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@DaveCTurner DaveCTurner changed the title Fix serialization of put-shutdown request Fix serialization of put/delete shutdown requests Apr 25, 2024
Copy link
Copy Markdown
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop
Copy link
Copy Markdown
Member

thecoop commented May 3, 2024

8.13 and 8.14 backports are #108250 and #108251 respectively. Note the interdependent uses of the 8.13 and 8.14 transport patch versions

@ldematte
Copy link
Copy Markdown
Contributor

ldematte commented May 3, 2024

Still good after the backports

@thecoop
Copy link
Copy Markdown
Member

thecoop commented May 3, 2024

@elasticmachine update branch

@thecoop thecoop merged commit eb90e36 into elastic:main May 3, 2024
thecoop added a commit that referenced this pull request May 3, 2024
thecoop added a commit that referenced this pull request May 3, 2024
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 21, 2024
Cleaning up the version logic added in elastic#107862 a little, and also
removing some usages of `TRAPPY_IMPLICIT_DEFAULT_MASTER_NODE_TIMEOUT` as
per elastic#107984.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 22, 2024
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2024
Cleaning up the version logic added in #107862 a little, and also
removing some usages of `TRAPPY_IMPLICIT_DEFAULT_MASTER_NODE_TIMEOUT` as
per #107984.
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown Team:Core/Infra Meta label for core/infra team v8.13.4 v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PutShutdownNodeAction.Request does not preserve parent task or timeouts on the wire

5 participants