Skip to content

(Doc+) Delineate Bootstrapping Data Stream from Alias#107976

Merged
stefnestor merged 2 commits intomainfrom
stefnestor-patch-6
May 2, 2024
Merged

(Doc+) Delineate Bootstrapping Data Stream from Alias#107976
stefnestor merged 2 commits intomainfrom
stefnestor-patch-6

Conversation

@stefnestor
Copy link
Copy Markdown
Member

👋 howdy, team!

This is follow-up to elasticsearch#107327. I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. (Sorry again.)

However, it seemed like a good opportunity to (A) fill in links & (B) consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Applied forward earlier feedback.

Thoughts? cc: @dakrone

👋 howdy, team! 

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?
@stefnestor stefnestor added >enhancement >docs General docs changes :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team labels Apr 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v8.15.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 26, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@shainaraskas shainaraskas self-requested a review April 29, 2024 15:33
Copy link
Copy Markdown
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@stefnestor stefnestor merged commit a3f3f59 into main May 2, 2024
@stefnestor stefnestor deleted the stefnestor-patch-6 branch May 2, 2024 17:07
shainaraskas added a commit to shainaraskas/elasticsearch that referenced this pull request Jun 21, 2024
* (Doc+) Delineate Bootstrapping Data Stream from Alias

👋 howdy, team!

This is follow-up to [elasticsearch#107327](elastic#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?

* Apply suggestions from code review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit a3f3f59)
@shainaraskas
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jun 21, 2024
)

* (Doc+) Delineate Bootstrapping Data Stream from Alias

👋 howdy, team!

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?

* Apply suggestions from code review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit a3f3f59)

Co-authored-by: Stef Nestor <26751266+stefnestor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants