Skip to content

(Doc+) Point ingest to Alias not Bootstrapped Index#107327

Merged
elasticsearchmachine merged 1 commit intomainfrom
stefnestor-patch-4
Apr 10, 2024
Merged

(Doc+) Point ingest to Alias not Bootstrapped Index#107327
elasticsearchmachine merged 1 commit intomainfrom
stefnestor-patch-4

Conversation

@stefnestor
Copy link
Copy Markdown
Member

👋 howdy, team!

Sometimes users believe they should point client-side (e.g. Logstash's Elasticsearch output index) to the bootstrapped index. This highlights they point ingest towards the alias.

cc: @dakrone

👋 @dakrone mentioned baby-update for docs. 

Sometimes users believe they should point client-side (e.g. Logstash's Elasticsearch output `index`) to the bootstrapped index. This highlights they point ingest towards the alias as we're expecting.
@stefnestor stefnestor added >docs General docs changes backport :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Apr 10, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

@stefnestor please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.14.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit 9a2bfb9 into main Apr 10, 2024
@elasticsearchmachine elasticsearchmachine deleted the stefnestor-patch-4 branch April 10, 2024 17:37
@dakrone
Copy link
Copy Markdown
Member

dakrone commented Apr 10, 2024

@stefnestor did you mean to merge this without any review?

@stefnestor
Copy link
Copy Markdown
Member Author

Uh, nope. Sorry. I meant it to auto-merge once approved, @dakrone .

You can search across all of the data stream's backing indices, managed by the `timeseries_policy`,
with the `timeseries` data stream name.
Write operations are routed to the current write index. Read operations will be handled by all
You will point ingest towards the alias which will route write operations to its current write index. Read operations will be handled by all
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing, because in this section, this is about creating the data stream, and there is no "alias" in play. It should read instead something like:

"Write operations should be sent to the data stream name, which will route them to its current write index. Read operations on the data stream will be handled by all backing indices."

@dakrone
Copy link
Copy Markdown
Member

dakrone commented Apr 10, 2024

@stefnestor okay, the auto-merge label works regardless of approval (it only checks CI), I left a comment on this PR though, because I think it's a little confusing. Can you open a new PR to fix this?

@stefnestor
Copy link
Copy Markdown
Member Author

For sure, sorry about that! I was label copying from your #107233 but didn't realize the two labels separate worked different than them together (or maybe that's a Lead-only thing).

But on what to fix, from the doc you updated it links to Manage time series data without data streams which links to Bootstrap the initial time series index with a write index alias which wouldn't be DataStreams within that context. Maybe instead ...

You will point ingest to the respective Data Stream / Alias that you set up which will automatically route write operations to its current write index.

@dakrone
Copy link
Copy Markdown
Member

dakrone commented Apr 11, 2024

Maybe instead ...

Can you open a new PR and we can work through this there?

craigtaverner pushed a commit to craigtaverner/elasticsearch that referenced this pull request Apr 11, 2024
👋 @dakrone mentioned baby-update for docs. 

Sometimes users believe they should point client-side (e.g. Logstash's Elasticsearch output `index`) to the bootstrapped index. This highlights they point ingest towards the alias as we're expecting.
stefnestor added a commit that referenced this pull request Apr 26, 2024
👋 howdy, team! 

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?
stefnestor added a commit that referenced this pull request May 2, 2024
* (Doc+) Delineate Bootstrapping Data Stream from Alias 

👋 howdy, team! 

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?

* Apply suggestions from code review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
shainaraskas added a commit to shainaraskas/elasticsearch that referenced this pull request Jun 21, 2024
* (Doc+) Delineate Bootstrapping Data Stream from Alias

👋 howdy, team!

This is follow-up to [elasticsearch#107327](elastic#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?

* Apply suggestions from code review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit a3f3f59)
elasticsearchmachine pushed a commit that referenced this pull request Jun 21, 2024
)

* (Doc+) Delineate Bootstrapping Data Stream from Alias

👋 howdy, team!

This is follow-up to [elasticsearch#107327](#107327). I realized my mistake was that we had duplicate sentences in different sections so I edited the wrong area. However, it seemed like a good opportunity to consider clarifying the page better by fixing header links so that the sub-sections reflect as sub-headers instead of all being equal. Thoughts?

* Apply suggestions from code review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit a3f3f59)

Co-authored-by: Stef Nestor <26751266+stefnestor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Data streams Data streams and their lifecycles Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants